Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make lint does not run on macOS #27

Open
jeyhun opened this issue Apr 7, 2023 · 0 comments
Open

make lint does not run on macOS #27

jeyhun opened this issue Apr 7, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jeyhun
Copy link
Contributor

jeyhun commented Apr 7, 2023

Describe the bug

make lint does not work on macOS, because it runs install_tools.sh script. The latter requires snap to already be present on the computer, which is not the case by default on macOS. Probably, it would be better if, for macOS, homebrew was used.

make lint
........
+ sudo snap install mdl
Password:
sudo: snap: command not found
make: *** [install_tools] Error 1

Reproduction steps

  1. Run make lint on macOS

Expected behavior

All the dependencies required by make lint should be installed automatically

Additional context

No response

@jeyhun jeyhun added the bug Something isn't working label Apr 7, 2023
@krishnamiriyala krishnamiriyala added enhancement New feature or request and removed bug Something isn't working labels May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants