[BUG] bitcoind cmake flags ignored on mac

[vnprc]

cmake ignores my build flags and nothing I have tried makes it work

% devenv shell --no-eval-cache
...
Fatal error, run database recovery
       > make[3]: *** [Makefile:22526: wallet/test/wallet_tests.cpp.test] Error 1
       > make[3]: Leaving directory '/private/tmp/nix-build-bitcoind-26.1.drv-0/bitcoin-26.1/src'
       > make[2]: *** [Makefile:20476: check-am] Error 2
       > make[2]: Leaving directory '/private/tmp/nix-build-bitcoind-26.1.drv-0/bitcoin-26.1/src'
       > make[1]: *** [Makefile:20141: check-recursive] Error 1
       > make[1]: Leaving directory '/private/tmp/nix-build-bitcoind-26.1.drv-0/bitcoin-26.1/src'
       > make: *** [Makefile:814: check-recursive] Error 1
       For full logs, run 'nix log /nix/store/2q6hri7rmyiq0iabfhwqybykwf0r4h2s-bitcoind-26.1.drv'.
error: 1 dependencies of derivation '/nix/store/kav1pzhdhjrxfn6xm9cdij1q2dmsg73f-bitcoind-sv2.drv' failed to build
error: 1 dependencies of derivation '/nix/store/vjhi732z0j8wr2n43bzsq9zdjn65awf2-devenv-profile.drv' failed to build
error:
       error: 2 dependencies of derivation '/nix/store/77m2is98qd49ghv51abmblda1mjfxp87-devenv-shell-env.drv' failed to build

✖ Command produced the following output:


✔ Building shell in 157.7s.
Error:   × Command `/nix/store/qm30w5jpw3fssz91g4sz6xmfh7bzf9ky-nix-2.24-devenv/bin/nix --show-trace --extra-experimental-features nix-command --extra-
  │ experimental-features flakes --option warn-dirty false --keep-going --max-jobs 6 --option eval-cache false --option extra-substituters https://
  │ devenv.cachix.org --option extra-trusted-public-keys devenv.cachix.org-1:w1cLUi8dv3hnoSPGAuibQv+f9TZLr6cv/Hm9XgU50cw= print-dev-env --profile /Users/
  │ evan/work/hashpool/.devenv/gc/shell` failed with with exit code 1

The log files indicate that it is building and testing the wallet code:

checking whether to build bitcoind... yes
checking whether to build bitcoin-cli... yes
checking whether to build bitcoin-tx... yes
checking whether to build bitcoin-wallet... yes
checking whether to build bitcoin-util... yes
checking whether to build experimental bitcoin-chainstate... no
checking whether to build libraries... yes
checking if ccache should be used... no
checking if wallet should be enabled... yes
checking whether to build with support for UPnP... yes
checking whether to build with support for NAT-PMP... no
checking whether to build test_bitcoin... yes
checking whether to reduce exports... no

even though bitcoind.nix explicitly disables these configs:

    cmakeFlags = [
      (lib.cmakeBool "WITH_SV2" true)
      (lib.cmakeBool "BUILD_BENCH" true)
      (lib.cmakeBool "BUILD_TESTS" true)
      (lib.cmakeBool "ENABLE_WALLET" false)
      (lib.cmakeBool "BUILD_GUI" false)
      (lib.cmakeBool "BUILD_GUI_TESTS" false)
    ];

[vnprc]

Removing the flags does nothing since that is ostensibly what is already happening. I just confirmed this on my machine with this code diff, which returned the same berkelydb test failure:

diff --git a/bitcoind.nix b/bitcoind.nix
index 0431ca57..d1db112a 100644
--- a/bitcoind.nix
+++ b/bitcoind.nix
@@ -21,14 +21,14 @@ in
     '';

     # Modify build settings
-    nativeBuildInputs = lib.lists.drop 1 oldAttrs.nativeBuildInputs ++ [pkgs.cmake];
-    postInstall = "";
-    cmakeFlags = [
-      (lib.cmakeBool "WITH_SV2" true)
-      (lib.cmakeBool "BUILD_BENCH" true)
-      (lib.cmakeBool "BUILD_TESTS" true)
-      (lib.cmakeBool "ENABLE_WALLET" false)
-      (lib.cmakeBool "BUILD_GUI" false)
-      (lib.cmakeBool "BUILD_GUI_TESTS" false)
-    ];
+    # nativeBuildInputs = lib.lists.drop 1 oldAttrs.nativeBuildInputs ++ [pkgs.cmake];
+    # postInstall = "";
+    # cmakeFlags = [
+    #   (lib.cmakeBool "WITH_SV2" true)
+    #   (lib.cmakeBool "BUILD_BENCH" true)
+    #   (lib.cmakeBool "BUILD_TESTS" true)
+    #   (lib.cmakeBool "ENABLE_WALLET" false)
+    #   (lib.cmakeBool "BUILD_GUI" false)
+    #   (lib.cmakeBool "BUILD_GUI_TESTS" false)
+    # ];
   })

[vnprc]

The smartest LLM I have access to suggested this fix to force disable autotools. This also did nothing. Same error output.

diff --git a/bitcoind.nix b/bitcoind.nix
index 0431ca57..31b8f383 100644
--- a/bitcoind.nix
+++ b/bitcoind.nix
@@ -9,6 +9,15 @@
     rev = "b4eb739e5d76e2b62fd37bae5da8acfa75484879";
     hash = "sha256-vRPVOjGt1bYQUWZycweaYI6y22O1K1QAaCh5u3rfP6Q=";
   };
+
+  cmakeFlagsStr = lib.concatStringsSep " " (map (f: "-D${f}") [
+    "WITH_SV2=ON"
+    "BUILD_BENCH=ON"
+    "BUILD_TESTS=ON"
+    "ENABLE_WALLET=OFF"
+    "BUILD_GUI=OFF"
+    "BUILD_GUI_TESTS=OFF"
+  ]);
 in
   pkgs.bitcoind.overrideAttrs (oldAttrs: {
     name = "bitcoind-sv2";
@@ -20,15 +29,33 @@ in
       echo "Skipping strict version check..."
     '';

-    # Modify build settings
-    nativeBuildInputs = lib.lists.drop 1 oldAttrs.nativeBuildInputs ++ [pkgs.cmake];
-    postInstall = "";
-    cmakeFlags = [
-      (lib.cmakeBool "WITH_SV2" true)
-      (lib.cmakeBool "BUILD_BENCH" true)
-      (lib.cmakeBool "BUILD_TESTS" true)
-      (lib.cmakeBool "ENABLE_WALLET" false)
-      (lib.cmakeBool "BUILD_GUI" false)
-      (lib.cmakeBool "BUILD_GUI_TESTS" false)
-    ];
+    # Ensure correct build tools are used
+    nativeBuildInputs = lib.lists.drop 1 oldAttrs.nativeBuildInputs ++ [pkgs.cmake pkgs.ninja];
+
+    # Force disable Autotools
+    configurePhase = ''true''; # **No-op to prevent Autotools from running** ✅
+
+    # Explicitly enforce CMake
+    buildPhase = '' # **Force CMake usage** ✅
+      runHook preBuild
+      rm -rf build  # Ensure clean build ✅
+      mkdir build && cd build
+      cmake .. -G Ninja ${cmakeFlagsStr}  # **Force CMake** ✅
+      cmake --build .
+      runHook postBuild
+    '';
+
+    checkPhase = ''
+      runHook preCheck
+      cd build
+      ctest --output-on-failure
+      runHook postCheck
+    '';
+
+    installPhase = ''
+      runHook preInstall
+      cd build
+      cmake --install .
+      runHook postInstall
+    '';
   })

I think it might be more productive to focus on getting a successful bitcoind build outside of a nix environment.

[vnprc]

reviewing #38 now

[vnprc]

edit: wrong place for this feedback, I will move discussion to the PR

it builds but for some reason jd-server doesn't want to talk to bitcoind

2025-05-01T13:22:22.758762Z  INFO jd_server::lib::job_declarator: JD INITIALIZED
2025-05-01T13:22:23.014840Z ERROR jd_server::lib::mempool::error: Rpc(Deserialization("EOF while parsing a value at line 1 column 0"))
2025-05-01T13:22:23.014855Z ERROR jd_server::lib::mempool::error: Unable to establish RPC connection with Template Provider (possible reasons: not fully synced, down)
2025-05-01T13:22:23.014895Z ERROR jd_server::lib: SHUTDOWN from Upstream: Mempool error: `Rpc(Deserialization("EOF while parsing a value at line 1 column 0"))`
Try to reconnecting or connecting to a new upstream

[vnprc]

Fixed and merged to master. Nice work Gary!