Skip to content

Built-in tool tasks miss the cache after the workspace moves #790

Open

Description

@lifeiscontent

Problem

When a task runs a built-in tool like vp lint or vp test, the planned command includes the absolute path of the tool's entry script, for example /home/me/project/node_modules/oxlint/bin/oxlint. That path is part of the cache key, so moving the workspace, cloning it somewhere else, or running from a git worktree misses the cache for every one of those tasks, even though nothing about them changed.

Proposal

Let the code that synthesizes these commands pass the tool's entry script separately from its other arguments. When the entry is inside the workspace, vp run passes it relative to the task's directory, in both the command it runs and the cache key. Everything else stays as it is today.

Related

#717 covers the case where the entry is outside the workspace, in a global pnpm store. That needs a different fix.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions