Commit dd3e593
committed
fix(benchmarks-migrate): route 2-part random-access to Skip, not Unknown
The post-alpha cleanup made `bin_random_access` reject 2-part legacy
shapes by returning None, but `classify_outcome` mapped any None bin
to `Outcome::Unknown`, so those records counted against the 5%
uncategorized gate. Intentional drops must Skip; only truly
unrecognized shapes are Unknown.
Reuses the existing `Skip::UnsupportedShape` variant, originally
added for "get_group succeeded but classify_v2 didn't" — same
semantic shape (recognized but unsupported).
Regression test in `tests/classifier.rs` exercises `classify_outcome`
(not just the top-level `classify`) so Skip vs Unknown is observable.
Signed-off-by: Claude <noreply@anthropic.com>1 parent 85e39f3 commit dd3e593
2 files changed
Lines changed: 27 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
537 | 537 | | |
538 | 538 | | |
539 | 539 | | |
540 | | - | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
541 | 550 | | |
542 | 551 | | |
543 | 552 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
271 | 271 | | |
272 | 272 | | |
273 | 273 | | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
274 | 291 | | |
275 | 292 | | |
276 | 293 | | |
| |||
0 commit comments