fix

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

vortex-duckdb/src/convert/expr.rs

@@ -44,11 +44,12 @@ fn like_pattern_str(value: &duckdb::ExpressionRef) -> VortexResult<Option<String
     }
 }
 
+#[allow(clippy::cognitive_complexity)]
 pub fn try_from_bound_expression(
     value: &duckdb::ExpressionRef,
 ) -> VortexResult<Option<Expression>> {
     let Some(value) = value.as_class() else {
-        tracing::debug!("no expression class id {:?}", value.as_class_id());
+        debug!("no expression class id {:?}", value.as_class_id());
         return Ok(None);
     };
     Ok(Some(match value {
@@ -164,7 +165,7 @@ pub fn try_from_bound_expression(
                 Like.new_expr(LikeOptions::default(), [value, pattern])
             }
             _ => {
-                tracing::debug!("bound function {}", func.scalar_function.name());
+                debug!("bound function {}", func.scalar_function.name());
                 return Ok(None);
             }
         },

vortex-duckdb/src/exporter/constant.rs

@@ -65,7 +65,7 @@ impl ColumnExporter for ConstantExporter {
     fn export(
         &self,
         _offset: usize,
-        _len: usize,
+        len: usize,
         vector: &mut VectorRef,
         _ctx: &mut ExecutionCtx,
     ) -> VortexResult<()> {

vortex-duckdb/src/exporter/vector.rs

@@ -2,7 +2,6 @@
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
 use vortex::mask::Mask;
-use vortex::mask::MaskValues;
 
 use crate::cpp::duckdb_vx_vector_set_all_valid;
 use crate::duckdb::Value;
@@ -31,7 +30,7 @@ impl VectorRef {
             Mask::Values(arr) => {
                 let true_count = arr.bit_buffer().slice(offset..(offset + len)).true_count();
                 if true_count == len {
-                    unsafe { self.set_all_true_validity(len) }
+                    self.set_all_true_validity()
                 } else if true_count == 0 {
                     self.set_all_false_validity()
                 } else if let Some(zc) = zero_copy.filter(|_| offset.is_multiple_of(64)) {