Skip to content

feat[array]: owned matchers#7238

Closed
joseph-isaacs wants to merge 2 commits into
developfrom
ji/owned-matchers
Closed

feat[array]: owned matchers#7238
joseph-isaacs wants to merge 2 commits into
developfrom
ji/owned-matchers

Conversation

@joseph-isaacs

@joseph-isaacs joseph-isaacs commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

We want to be able to downcast arrays based on a matcher into an owned type.

open questions:

We could extend array try_into to use a matcher

@joseph-isaacs joseph-isaacs added the changelog/feature A new feature label Apr 1, 2026
@joseph-isaacs joseph-isaacs requested a review from gatesn April 1, 2026 11:26
@joseph-isaacs joseph-isaacs marked this pull request as ready for review April 1, 2026 11:26
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) April 1, 2026 12:31

@gatesn gatesn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is subsumed by #7215

@joseph-isaacs

Copy link
Copy Markdown
Contributor Author

Mind showing which part?

@github-actions

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Apr 21, 2026
@joseph-isaacs

Copy link
Copy Markdown
Contributor Author

@gatesn I think we still want this correct?

joseph-isaacs and others added 2 commits May 12, 2026 14:16
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace borrow-then-clone patterns with owned matchers:
- filter/masked vtable: use into_::<AnyCanonical>() instead of
  Canonical::from(child.as_::<AnyCanonical>())
- canonical/columnar Executable: use try_into_matched instead of
  as_opt + Canonical::from
- dict take_canonical: accept owned Canonical directly

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codspeed-hq

codspeed-hq Bot commented May 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 2 improved benchmarks
❌ 6 regressed benchmarks
✅ 1202 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation varbinview_zip_block_mask 3.7 ms 2.9 ms +27.72%
Simulation varbinview_zip_fragmented_mask 6.9 ms 6.2 ms +12.73%
Simulation new_bp_prim_test_between[i16, 32768] 121 µs 134.9 µs -10.29%
Simulation new_bp_prim_test_between[i32, 32768] 141.8 µs 170.6 µs -16.85%
Simulation new_bp_prim_test_between[i64, 32768] 178.9 µs 237.4 µs -24.65%
Simulation new_bp_prim_test_between[i64, 16384] 116 µs 145.2 µs -20.1%
Simulation new_bp_prim_test_between[i32, 16384] 95.5 µs 109.8 µs -13.01%
Simulation new_alp_prim_test_between[f64, 16384] 127.8 µs 149.5 µs -14.46%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ji/owned-matchers (be75eca) with develop (e56c80d)

Open in CodSpeed

@github-actions github-actions Bot removed the stale This PR is stale and will be auto-closed soon label May 18, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Jun 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions Bot closed this Jun 11, 2026
auto-merge was automatically disabled June 11, 2026 02:18

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature stale This PR is stale and will be auto-closed soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants