feat[array]: owned matchers#7238
Conversation
|
Mind showing which part? |
|
This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
|
@gatesn I think we still want this correct? |
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace borrow-then-clone patterns with owned matchers: - filter/masked vtable: use into_::<AnyCanonical>() instead of Canonical::from(child.as_::<AnyCanonical>()) - canonical/columnar Executable: use try_into_matched instead of as_opt + Canonical::from - dict take_canonical: accept owned Canonical directly Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e08c98f to
be75eca
Compare
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | varbinview_zip_block_mask |
3.7 ms | 2.9 ms | +27.72% |
| ⚡ | Simulation | varbinview_zip_fragmented_mask |
6.9 ms | 6.2 ms | +12.73% |
| ❌ | Simulation | new_bp_prim_test_between[i16, 32768] |
121 µs | 134.9 µs | -10.29% |
| ❌ | Simulation | new_bp_prim_test_between[i32, 32768] |
141.8 µs | 170.6 µs | -16.85% |
| ❌ | Simulation | new_bp_prim_test_between[i64, 32768] |
178.9 µs | 237.4 µs | -24.65% |
| ❌ | Simulation | new_bp_prim_test_between[i64, 16384] |
116 µs | 145.2 µs | -20.1% |
| ❌ | Simulation | new_bp_prim_test_between[i32, 16384] |
95.5 µs | 109.8 µs | -13.01% |
| ❌ | Simulation | new_alp_prim_test_between[f64, 16384] |
127.8 µs | 149.5 µs | -14.46% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ji/owned-matchers (be75eca) with develop (e56c80d)
|
This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
Pull request was closed
We want to be able to downcast arrays based on a matcher into an owned type.
open questions:
We could extend array try_into to use a matcher