validate all benchmark runs#6939
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Polar Signals Profiling ResultsLatest Run
Previous Runs (5)
Powered by Polar Signals Cloud |
Merging this PR will improve performance by 20%
Performance Changes
Comparing Footnotes
|
Benchmarks: TPC-H SF=1 on S3Verdict: Likely regression (environment too noisy confidence) datafusion / vortex-file-compressed (0.896x ➖, 9↑ 5↓)
datafusion / vortex-compact (1.232x ➖, 1↑ 10↓)
datafusion / parquet (0.926x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (1.056x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.075x ➖, 0↑ 2↓)
duckdb / parquet (0.321x ✅, 22↑ 0↓)
Full attributed analysis
|
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.062x ➖, 0↑ 2↓)
datafusion / vortex-compact (1.067x ➖, 0↑ 2↓)
datafusion / parquet (1.066x ➖, 0↑ 4↓)
datafusion / arrow (1.054x ➖, 0↑ 5↓)
duckdb / vortex-file-compressed (1.020x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.007x ➖, 0↑ 0↓)
duckdb / parquet (1.003x ➖, 3↑ 5↓)
duckdb / duckdb (0.896x ✅, 12↑ 1↓)
Full attributed analysis
|
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.016x ➖, 0↑ 1↓)
datafusion / vortex-compact (0.990x ➖, 1↑ 1↓)
datafusion / parquet (0.969x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (1.023x ➖, 1↑ 2↓)
duckdb / vortex-compact (0.966x ➖, 1↑ 0↓)
duckdb / parquet (0.968x ➖, 0↑ 0↓)
Full attributed analysis
|
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.935x ➖, 14↑ 0↓)
datafusion / vortex-compact (0.968x ➖, 1↑ 0↓)
datafusion / parquet (0.952x ➖, 4↑ 0↓)
duckdb / vortex-file-compressed (0.959x ➖, 6↑ 0↓)
duckdb / vortex-compact (0.989x ➖, 6↑ 2↓)
duckdb / parquet (0.972x ➖, 3↑ 0↓)
duckdb / duckdb (0.972x ➖, 4↑ 0↓)
Full attributed analysis
|
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.000x ➖ datafusion / vortex-file-compressed (1.000x ➖, 0↑ 0↓)
|
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.033x ➖, 0↑ 1↓)
datafusion / vortex-compact (1.138x ➖, 0↑ 2↓)
datafusion / parquet (1.088x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (1.214x ➖, 0↑ 2↓)
duckdb / vortex-compact (1.072x ➖, 0↑ 1↓)
duckdb / parquet (1.030x ➖, 0↑ 0↓)
Full attributed analysis
|
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (0.959x ➖, 2↑ 0↓)
duckdb / vortex-compact (1.001x ➖, 0↑ 0↓)
duckdb / parquet (0.985x ➖, 0↑ 0↓)
Full attributed analysis
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Benchmarks: Random AccessVortex (geomean): 0.804x ✅ unknown / unknown (0.887x ✅, 29↑ 0↓)
|
Benchmarks: CompressionVortex (geomean): 0.958x ➖ unknown / unknown (0.955x ➖, 9↑ 14↓)
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # Cargo.lock
| reqwest = { workspace = true, features = ["stream"] } | ||
| serde = { workspace = true, features = ["derive"] } | ||
| serde_json = { workspace = true } | ||
| sqllogictest = "0.28" |
There was a problem hiding this comment.
IDK how this works, we're on 0.29
| @@ -0,0 +1,24 @@ | |||
| # TPC-H benchmark queries — datafusion expected results. | |||
|
|
|||
| include queries/bench_01_datafusion.slt | |||
There was a problem hiding this comment.
slt should support queries/*.slt
| @@ -0,0 +1,24 @@ | |||
| # TPC-H benchmark queries — duckdb expected results. | |||
|
|
|||
| include queries/bench_01_duckdb.slt | |||
There was a problem hiding this comment.
slt should support queries/*.slt
| @@ -0,0 +1,36 @@ | |||
| # ClickBench benchmark queries — duckdb expected results. | |||
|
|
|||
| include queries/bench_00.slt | |||
There was a problem hiding this comment.
slt should support queries/*.slt
| @@ -0,0 +1,37 @@ | |||
| # ClickBench benchmark queries — datafusion expected results. | |||
|
|
|||
| include queries/bench_00.slt | |||
There was a problem hiding this comment.
slt should support queries/*.slt
|
SLT has a |
AdamGS
left a comment
There was a problem hiding this comment.
This LGTM overall, just some relatively minor comments
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # Cargo.lock # benchmarks/datafusion-bench/src/main.rs
|
This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
Use slt (sql logic test) to validate benchmark runs.