Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: singer-io/tap-facebook
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: voxmedia/tap-facebook
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 18 commits
  • 8 files changed
  • 5 contributors

Commits on Jul 12, 2022

  1. Added video_thruplay_watched_actions and video_play_actions fields 

    Added video_thruplay_watched_actions and video_play_actions fields to ads_insights and ads_insights_platform_and_device
    @dkasi938
    dkasi938 committed Jul 12, 2022
    Copy the full SHA
    3399918 View commit details

Commits on Jul 15, 2022

  1. Merge pull request #1 from voxmedia/additional-video-metric-fields 

    Added video_thruplay_watched_actions and video_play_actions fields
    @diwakarkasi
    diwakarkasi authored Jul 15, 2022
    Copy the full SHA
    0e74731 View commit details

Commits on Aug 24, 2022

  1. handle fb_error['body']['error'] being string instead of dict

    @prratek
    prratek committed Aug 24, 2022
    Copy the full SHA
    ec27ba2 View commit details

  2. Merge pull request #2 from voxmedia/attribute-error-fix 

    handle fb_error['body']['error'] being string instead of dict
    @prratek
    prratek authored Aug 24, 2022
    Copy the full SHA
    4a57efa View commit details

Commits on Feb 1, 2023

  1. Merge branch 'singer-io:master' into master

    @hkuffel
    hkuffel authored Feb 1, 2023
    Copy the full SHA
    b9cf6b7 View commit details

Commits on Mar 16, 2023

  1. Bump version to 16.0

    @dkasi938
    dkasi938 committed Mar 16, 2023
    Copy the full SHA
    b832636 View commit details

  2. Merge pull request #4 from voxmedia/dk-bump-version-16 

    Bump FB Business version from 14.0 to 16.0
    @diwakarkasi
    diwakarkasi authored Mar 16, 2023
    Copy the full SHA
    5276d80 View commit details

Commits on Jun 30, 2023

  1. Update setup.py

    @dkasi938
    dkasi938 committed Jun 30, 2023
    Copy the full SHA
    171280a View commit details

  2. Merge pull request #5 from voxmedia/dk-bump-fb-version 

    Bump FB version to 17.0.2
    @diwakarkasi
    diwakarkasi authored Jun 30, 2023
    Copy the full SHA
    1731414 View commit details

Commits on Aug 16, 2023

  1. Update setup.py

    @dkasi938
    dkasi938 committed Aug 16, 2023
    Copy the full SHA
    f88cf9d View commit details

Commits on Dec 7, 2023

  1. Add video_p95_watched_actions

    @dkasi938
    dkasi938 committed Dec 7, 2023
    Copy the full SHA
    8f65bb3 View commit details

  2. Update setup.py

    @dkasi938
    dkasi938 committed Dec 7, 2023
    Copy the full SHA
    b114ecd View commit details

  3. Update setup.py

    @dkasi938
    dkasi938 committed Dec 7, 2023
    Copy the full SHA
    d43d9a6 View commit details

Commits on Dec 11, 2023

  1. Update setup.py

    @dkasi938
    dkasi938 committed Dec 11, 2023
    Copy the full SHA
    8b1e457 View commit details

Commits on Dec 12, 2023

  1. Update setup.py

    @dkasi938
    dkasi938 committed Dec 12, 2023
    Copy the full SHA
    e2ad893 View commit details

  2. Merge pull request #6 from voxmedia/dk-fbads-95pctviews-dt2922 

    Add Video 95Pct views
    @diwakarkasi
    diwakarkasi authored Dec 12, 2023
    Copy the full SHA
    1cfd818 View commit details

Commits on Aug 14, 2024

  1. Update setup.py

    @dkasi938
    dkasi938 committed Aug 14, 2024
    Copy the full SHA
    ed93938 View commit details

  2. Merge pull request #7 from voxmedia/dk-bump-fb-ads-version 

    Bump FB Ads version to 19.0.2
    @diwakarkasi
    diwakarkasi authored Aug 14, 2024
    Copy the full SHA
    54eec12 View commit details
4 changes: 2 additions & 2 deletions setup.py
View file
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
from setuptools import setup

setup(name='tap-facebook',
version='1.18.4',
version='1.19.0',
description='Singer.io tap for extracting data from the Facebook Ads API',
author='Stitch',
url='https://singer.io',
@@ -13,7 +13,7 @@
'attrs==17.3.0',
'backoff==1.8.0',
'pendulum==1.2.0',
'facebook_business==14.0.0',
'facebook_business==19.0.2',
'requests==2.20.0',
'singer-python==5.10.0',
],
7 changes: 6 additions & 1 deletion tap_facebook/__init__.py
View file
Original file line number Diff line number Diff line change
@@ -127,10 +127,15 @@ def raise_from(singer_error, fb_error):
"""
if isinstance(fb_error, FacebookRequestError):
http_method = fb_error.request_context().get('method', 'Unknown HTTP Method')
fb_error_body = fb_error.body().get('error', {})
if isinstance(fb_error_body, dict):
fb_error_message = fb_error_body.get('message')
else:
fb_error_message = fb_error_body
error_message = '{}: {} Message: {}'.format(
http_method,
fb_error.http_status(),
fb_error.body().get('error', {}).get('message')
fb_error_message
)
else:
# All other facebook errors are `FacebookError`s and we handle
3 changes: 3 additions & 0 deletions tap_facebook/schemas/ads_insights.json
View file
Original file line number Diff line number Diff line change
@@ -13,7 +13,10 @@
"video_p25_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p50_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p75_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p95_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p100_watched_actions": {"$ref": "ads_action_stats.json"},
"video_thruplay_watched_actions": {"$ref": "ads_action_stats.json"},
"video_play_actions": {"$ref": "ads_action_stats.json"},
"video_play_curve_actions": {"$ref": "ads_histogram_stats.json"},
"clicks": {
"type": [
1 change: 1 addition & 0 deletions tap_facebook/schemas/ads_insights_age_and_gender.json
View file
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@
"video_p25_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p50_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p75_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p95_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p100_watched_actions": {"$ref": "ads_action_stats.json"},
"video_play_curve_actions": {"$ref": "ads_histogram_stats.json"},
"clicks": {
1 change: 1 addition & 0 deletions tap_facebook/schemas/ads_insights_country.json
View file
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@
"video_p25_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p50_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p75_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p95_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p100_watched_actions": {"$ref": "ads_action_stats.json"},
"video_play_curve_actions": {"$ref": "ads_histogram_stats.json"},
"clicks": {
1 change: 1 addition & 0 deletions tap_facebook/schemas/ads_insights_dma.json
View file
Original file line number Diff line number Diff line change
@@ -10,6 +10,7 @@
"video_p25_watched_actions": { "$ref": "ads_action_stats.json" },
"video_p50_watched_actions": { "$ref": "ads_action_stats.json" },
"video_p75_watched_actions": { "$ref": "ads_action_stats.json" },
"video_p95_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p100_watched_actions": { "$ref": "ads_action_stats.json" },
"video_play_curve_actions": {"$ref": "ads_histogram_stats.json"},
"clicks": {
3 changes: 3 additions & 0 deletions tap_facebook/schemas/ads_insights_platform_and_device.json
View file
Original file line number Diff line number Diff line change
@@ -13,7 +13,10 @@
"video_p25_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p50_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p75_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p95_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p100_watched_actions": {"$ref": "ads_action_stats.json"},
"video_thruplay_watched_actions": {"$ref": "ads_action_stats.json"},
"video_play_actions": {"$ref": "ads_action_stats.json"},
"video_play_curve_actions": {"$ref": "ads_histogram_stats.json"},
"impression_device": {
"type": [
1 change: 1 addition & 0 deletions tap_facebook/schemas/ads_insights_region.json
View file
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@
"video_p25_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p50_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p75_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p95_watched_actions": {"$ref": "ads_action_stats.json"},
"video_p100_watched_actions": {"$ref": "ads_action_stats.json"},
"video_play_curve_actions": {"$ref": "ads_histogram_stats.json"},
"clicks": {