You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
.github/workflows/test.yml contains a commented-out beaker_in_container acceptance job that ran Beaker itself inside a container (with DOCKER_IN_DOCKER=true) and then provisioned test containers from there. It was disabled with the note:
this job is currently broken because puppet/puppet-dev-tools:2023-02-24-1bca42e is too old
Why it matters
Some code paths in the hypervisor only trigger when Beaker runs inside a container, and none of the current CI jobs exercise them:
in_container? — used to decide whether to connect to test containers via the container network gateway/IP instead of a published host port. Fix ssh connection routing under Podman: network naming and container detection #194 extends this check to detect Podman containers (/run/.containerenv in addition to /.dockerenv), but CI can't currently validate either variant.
The gateway-based connection routing in get_ssh_connection_info (the DOCKER_IN_DOCKER / in_container? branch).
Suggested work
Revive the beaker_in_container job with a maintained image (or just a plain Ruby image with bundle install, as the old step already did).
Background
.github/workflows/test.ymlcontains a commented-outbeaker_in_containeracceptance job that ran Beaker itself inside a container (withDOCKER_IN_DOCKER=true) and then provisioned test containers from there. It was disabled with the note:Why it matters
Some code paths in the hypervisor only trigger when Beaker runs inside a container, and none of the current CI jobs exercise them:
in_container?— used to decide whether to connect to test containers via the container network gateway/IP instead of a published host port. Fix ssh connection routing under Podman: network naming and container detection #194 extends this check to detect Podman containers (/run/.containerenvin addition to/.dockerenv), but CI can't currently validate either variant.get_ssh_connection_info(theDOCKER_IN_DOCKER/in_container?branch).Suggested work
beaker_in_containerjob with a maintained image (or just a plain Ruby image withbundle install, as the old step already did)./run/.containerenvdetection path from Fix ssh connection routing under Podman: network naming and container detection #194 is covered too.Follow-up from the review discussion on #194.