Skip to content

CI: re-enable the beaker_in_container acceptance job to cover in-container connection routing #195

Description

@miharp

Background

.github/workflows/test.yml contains a commented-out beaker_in_container acceptance job that ran Beaker itself inside a container (with DOCKER_IN_DOCKER=true) and then provisioned test containers from there. It was disabled with the note:

this job is currently broken because puppet/puppet-dev-tools:2023-02-24-1bca42e is too old

Why it matters

Some code paths in the hypervisor only trigger when Beaker runs inside a container, and none of the current CI jobs exercise them:

  • in_container? — used to decide whether to connect to test containers via the container network gateway/IP instead of a published host port. Fix ssh connection routing under Podman: network naming and container detection #194 extends this check to detect Podman containers (/run/.containerenv in addition to /.dockerenv), but CI can't currently validate either variant.
  • The gateway-based connection routing in get_ssh_connection_info (the DOCKER_IN_DOCKER / in_container? branch).

Suggested work

Follow-up from the review discussion on #194.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions