Clean tree, fix test setup and minor code fix

Author: Valantin

.github/workflows/ci.yml

@@ -20,3 +20,5 @@ jobs:
   puppet:
     name: Puppet
     uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v3
+    with:
+      beaker_hosts: 'vpnserver:ma;vpnclienta:a'

.sync.yml

@@ -1,5 +1,6 @@
 ---
-spec/spec_helper.rb:
-  hiera_config: "'spec/fixtures/hiera/hiera.yaml'"
 spec/spec_helper_acceptance.rb:
   unmanaged: false
+.github/workflows/ci.yml:
+  with:
+    beaker_hosts: 'vpnserver:ma;vpnclienta:a'

Vagrantfile

@@ -4,9 +4,9 @@
 class openvpn::install {
   include openvpn
 
-  ensure_packages(['openvpn'])
+  stdlib::ensure_packages(['openvpn'])
   if $openvpn::additional_packages {
-    ensure_packages($openvpn::additional_packages)
+    stdlib::ensure_packages($openvpn::additional_packages)
   }
 
   if $facts['os']['family'] == 'Archlinux' {

manifests/install.pp

@@ -55,7 +55,7 @@
   }
 
   if ($openvpn::easyrsa_version == '3.0') {
-    exec { "copy renewed crl.pem to ${name} keys directory because of revocation of ${name}":
+    exec { "copy renewed crl.pem to ${server} keys directory because of revocation of ${name}":
       command     => "cp ${server_directory}/${server}/easy-rsa/keys/crl.pem ${server_directory}/${server}/crl.pem",
       subscribe   => Exec["renew crl.pem on ${server} because of revocation of ${name}"],
       provider    => 'shell',