Versions 3 Upgrade guide for none-vscode editors. #5456
Replies: 7 comments 36 replies
-
|
Hey guys 👋🏻 I'm encountering an error in a newly created project (using I obviously added a couple of log lines: I'm sure I'm missing something simple. Thanks in advance! |
Beta Was this translation helpful? Give feedback.
-
|
mason is indeed blocked at v1 in LazyVim source code 😢 There is an open PR at LazyVim/LazyVim#6053 (comment) with a workaround. I used that and your version with vue_ls instead of volar and it works! Thanks a ton for taking a look and helping me out ❤️
I know but I feel like it's the same issue otherwise: I will have to maintain it myself like I used to when it was vim and at some point things just break again 🫠 |
Beta Was this translation helpful? Give feedback.
-
|
@RayGuo-ergou thanks, but I found that this configuration doesn't work on nuxt2.
|
Beta Was this translation helpful? Give feedback.
-
|
why "gd" not working here, something wrong? |
Beta Was this translation helpful? Give feedback.
-
|
@fnet123 I have noticed your typescript version is |
Beta Was this translation helpful? Give feedback.
-
|
@cjnchk cannot reproduce from my side(lazy to do a gif, but gd works) |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't seem to be working correctly in Helix for me.
Here is my configuration: My setup is based on the discussion in helix-editor/helix#10691 and https://github.com/helix-editor/helix/blob/25.01.1/languages.toml#L119. The only modification I've made is removing the hybridMode and tsdk settings. Am I missing any necessary configuration? |
Beta Was this translation helpful? Give feedback.
-
|
Hi I doubt you are using v3 of the lsp because it does require the request forwarding, if helix can only config the editor via toml file and there's no plugin system (as far as i know there's not) I would recommend just stay at v2 if everything goes right for v2. |
Beta Was this translation helpful? Give feedback.
-
It's working perfectly now, and the performance of vtsls is even better than I expected. |
Beta Was this translation helpful? Give feedback.
-
|
I suspect that your configuration only uses vtsls + |
Beta Was this translation helpful? Give feedback.
-
You're right, I forgot that I had removed the vue-language-server related configuration. I've re-added vuels to the language server for .vue files, and now everything seems to be working correctly. (This is on a different Arch Linux machine, so the paths are slightly different from before.) |
Beta Was this translation helpful? Give feedback.
-
|
I don't think your current language feature complete if you don't have implement this.
|
Beta Was this translation helpful? Give feedback.
-
|
Hi I have a follow-up question / issue :) I'm using inlay hints (https://github.com/yamafaktory/.config/blob/2f18977151a3a2fccf90e942c083051f070514e8/nvim/init.lua#L668) and somehow facing this issue quite often: Error in decoration provider "win" (ns=nvim.lsp.inlayhint):
Error executing lua: /usr/share/nvim/runtime/lua/vim/lsp/inlay_hint.lua:349: Invalid 'col': out of range
stack traceback:
[C]: in function 'nvim_buf_set_extmark'
/usr/share/nvim/runtime/lua/vim/lsp/inlay_hint.lua:349: in function </usr/share/nvim/runtime/lua/vim/lsp/inlay_hint.lua:303>Any idea? Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Maybe related #5471 |
Beta Was this translation helpful? Give feedback.
-
|
I have a question about hover, why can't I hover to the 中文准确描述: 我在 
Here is my config: return function()
local vue_language_server_path = vim.fn.expand('$MASON/packages')
.. '/vue-language-server'
.. '/node_modules/@vue/language-server'
local vue_plugin = {
name = '@vue/typescript-plugin',
location = vue_language_server_path,
languages = { 'vue' },
configNamespace = 'typescript',
}
local shared_config = {
suggest = { completeFunctionCalls = true },
inlayHints = {
parameterNames = { enabled = 'all', suppressWhenArgumentMatchesName = false },
parameterTypes = { enabled = true },
variableTypes = { enabled = true, suppressWhenTypeMatchesName = false },
propertyDeclarationTypes = { enabled = true },
functionLikeReturnTypes = { enabled = true },
enumMemberValues = { enabled = true },
},
}
local vtsls_config = {
settings = {
vtsls = {
experimental = {
completion = {
enableServerSideFuzzyMatch = true,
},
},
tsserver = {
globalPlugins = {
vue_plugin,
},
},
},
typescript = shared_config,
javascript = shared_config,
},
filetypes = {
'typescript',
'javascript',
'javascriptreact',
'typescriptreact',
'vue',
},
on_attach = function(client, bufnr)
if vim.bo[bufnr].filetype == 'vue' then
client.server_capabilities.semanticTokensProvider.full = false
end
end,
}
local vue_ls_config = {
on_attach = function(client, bufnr)
client.server_capabilities.semanticTokensProvider.full = true
end,
}
vim.lsp.config('vtsls', vtsls_config) -- vue 文件 ts部分支持
vim.lsp.config('vue_ls', vue_ls_config) -- vue文件 html css支持
vim.lsp.enable({
'vtsls',
'vue_ls',
})
-- 注册LSP附加回调
vim.api.nvim_create_autocmd('VimEnter', {
callback = function()
-- 设置高亮组 @lsp.type.component 链接到 @type 默认组件绿
vim.api.nvim_command('highlight link @lsp.type.component @type')
-- vim.api.nvim_set_hl(0, '@lsp.type.component', {
-- fg = color_table.vue_component_color,
-- bold = true,
-- })
end,
})
-- vim.lsp.inlay_hint.enable()
end |
Beta Was this translation helpful? Give feedback.
-
cannot reproduce on my end, and it has nothing to do with neither |
Beta Was this translation helpful? Give feedback.
-
|
emm, no it's not, it doesn't work for me using the native method either, I've tried both the 
|
Beta Was this translation helpful? Give feedback.
-
|
You are using the wrong method for checking diagnostic messages, see To me there's nothing wrong with your config, you are just not calling the correct api. |
Beta Was this translation helpful? Give feedback.
-
|
You're right. I'm dizzy. thanks |
Beta Was this translation helpful? Give feedback.
-
|
typescript-language-server now supports tsserver/request: |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
i tried to submit a PR to wiki/Neovim.md but i do not have permission to push to wiki repo. kindly make the following changes to Neovim.md in wiki:
> If you are on the recent `nvim-lspconfig`, you do **NOT** have to config `on_init`. See: https://github.com/neovim/nvim-lspconfig/pull/3943
-- If you are using mason.nvim, you can get the ts_plugin_path like this
-- For Mason v1,
-- local mason_registry = require('mason-registry')
-- local vue_language_server_path = mason_registry.get_package('vue-language-server'):get_install_path() .. '/node_modules/@vue/language-server'
-- For Mason v2,
-- local vue_language_server_path = vim.fn.expand '$MASON/packages' .. '/vue-language-server' .. '/node_modules/@vue/language-server'
-- or even
-- local vue_language_server_path = vim.fn.stdpath('data') .. "/mason/packages/vue-language-server/node_modules/@vue/language-server"
-- IMPORTANT: nvchad users cannot use `$MASON` directly as the option is set to `skip`, see: https://github.com/NvChad/NvChad/blob/29ebe31ea6a4edf351968c76a93285e6e108ea08/lua/nvchad/configs/mason.lua#L4
local vue_language_server_path = '/path/to/@vue/language-server'
-- nvim 0.11 or above
local cfg = vim.lsp.config.ts_ls
-- nvim below 0.11
-- local cfg = require("lspconfig").ts_ls.config_def.default_config
local tsserver_filetypes = (cfg and cfg.filetypes) or {}
local vue_plugin = {
name = '@vue/typescript-plugin',
location = vue_language_server_path,
languages = { 'vue' },
configNamespace = 'typescript',
}
local vtsls_config = {
settings = {
vtsls = {
tsserver = {
globalPlugins = {
vue_plugin,
},
},
},
},
filetypes = tsserver_filetypes,
table.insert(tsserver_filetypes, "vue")
}
local ts_ls_config = {
init_options = {
plugins = {
vue_plugin,
},
},
filetypes = tsserver_filetypes,
table.insert(tsserver_filetypes, "vue")
}
-- If you are on most recent `nvim-lspconfig`
local vue_ls_config = {}
-- If you are not on most recent `nvim-lspconfig` or you want to override
local vue_ls_config = {
on_init = function(client)
client.handlers['tsserver/request'] = function(_, result, context)
local ts_clients = vim.lsp.get_clients({ bufnr = context.bufnr, name = 'ts_ls' })
local vtsls_clients = vim.lsp.get_clients({ bufnr = context.bufnr, name = 'vtsls' })
local clients = {}
vim.list_extend(clients, ts_clients)
vim.list_extend(clients, vtsls_clients)
if #clients == 0 then
vim.notify('Could not find `vtsls` or `ts_ls` lsp client, `vue_ls` would not work without it.', vim.log.levels.ERROR)
return
end
local ts_client = clients[1]
local param = unpack(result)
local id, command, payload = unpack(param)
ts_client:exec_cmd({
title = 'vue_request_forward', -- You can give title anything as it's used to represent a command in the UI, `:h Client:exec_cmd`
command = 'typescript.tsserverRequest',
arguments = {
command,
payload,
},
}, { bufnr = context.bufnr }, function(_, r)
local response = r and r.body
-- TODO: handle error or response nil here, e.g. logging
-- NOTE: Do NOT return if there's an error or no response, just return nil back to the vue_ls to prevent memory leak
local response_data = { { id, response } }
---@diagnostic disable-next-line: param-type-mismatch
client:notify('tsserver/response', response_data)
end)
end
end,
}
-- nvim 0.11 or above
vim.lsp.config('vtsls', vtsls_config)
vim.lsp.config('vue_ls', vue_ls_config)
vim.lsp.config('ts_ls', ts_ls_config)
vim.lsp.enable({'vtsls', 'vue_ls'}) -- If using `ts_ls` replace `vtsls` to `ts_ls`
-- nvim below 0.11
local lspconfig = require('lspconfig')
-- If using vtsls
lspconfig.vtsls.setup vtsls_config
-- If using ts_ls
lspconfig.ts_ls.setup ts_ls_config
lspconfig.vue_ls.setup vue_ls_configfiletypes property of ts_ls has been updated from value: { 'typescript', 'javascript', 'javascriptreact', 'typescriptreact' } to: { 'javascript', 'javascriptreact', 'javascript.jsx', 'typescript', This new configuration will use table.insert() function of lua to |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for your comment, but we want the wiki to guide people on how to set up the LSP in most straight forward way, not to mix in opinionated ways of doing that.
I dont see the different
The config should be general and depends other plugins as little as possible, hard coded filetypes is a simple starting point, of course in your config you can do what every you want/need.
The filetype ended with |
Beta Was this translation helpful? Give feedback.
-
If you are on the recent `nvim-lspcofing`, fix: If you are on the recent `nvim-lspconfig`, config instructions, as on the wiki, do not work because tsserver_filetypes does not overwrite filetypes property of lspconfig.ts_ls. For new comers to vue_ls, like myself, it took ages to figure out the correct way to edit filetypes property because assigning tsserver_filetypes value to filetypes property fails silently. I found the root cause to be incorrect values assigned to tsserver_filetypes variable because the original values, as in the neovim lspconfig, are different. tsserver_filetypes values as on wiki: { 'typescript', 'javascript', 'javascriptreact', 'typescriptreact', 'vue' } you can see the values for yourself in the The proposed config not only work ootb but they also do not depend on any other plugin. at the very least, you need to assign the same values as in lspconfig +
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
TLDR: In version 3, there's one breaking change that require handled at lsp client side. For example, see how neovim config it here
What has changed and why?
For the user side, there are two things changed:
The way vue language server communicate with typescript language server.
In version 2, in order to drop the takeover mode for a more compatible solution with typescript language server, another layer of complexity was introduced (named pipes server) to help vue language server communicate with typescript language server(vue tsserver plugin). However, it seems caused many issues since v2 was released. Therefore, in the new major version, it has been removed and the responsibility of communication transferred to the lsp client side.
Option
typescript.tsdkhas dropped.Now
typescriptis a peer dependency. See detail hereHow do I migrate to version 3?
Migrating to version 3 is quite simple, create a client handler for vue language server, when receiving the request, forward it to typescript language server and finally send the payload from typescript language server back to vue language server. We have an example for neovim users here.
FAQ
What's the request and response name I should handle/send to vue language server?
The request and response names are not configurable:
tsserver/requesttsserver/responseCan I use any existing typescript language server?
No, vue LSP currently only work withvtsls.The reason is that ts_ls Currently does not handle the commandtypescript.tsserverRequestsee: https://github.com/typescript-language-server/typescript-language-server/blob/0a034dae6c777733f4c2f6d5b151c5ef781fb662/src/lsp-server.ts#L838-L940Since https://github.com/typescript-language-server/typescript-language-server/releases/tag/v4.4.0, both
vtslsandts_lsare supported.I cannot get it to work.
If you cannot get the vue language server to work, there's few things you can check yourself first:
tsserver/requestand what's the typescript language server response etc.If thing really not working on your machine please open a new issue with a Minimal Reproduction for both your vue project and editor configuration. (We do not have experience in all editors, so we might need the community's help.)
Beta Was this translation helpful? Give feedback.
All reactions