fix: install devtools plugin only after app is created and installed (#1063) #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinia-official canceled.
|
|
Thanks for the PR but this completely changes the behavior of plugins. The fix should be possible with minimal changes and without changing how stores are initialized |
|
OK, I ended up applying same logic to devtools plugin only. |
popov-a-e
changed the title
|
@posva Hi Eduardo, is it OK now? |
posva
requested changes
Oct 6, 2022
There was a problem hiding this comment.
Thanks but we really want to avoid adding any new hook like this.
Instead, let's move this kind of logic to the devtools: if the registerPiniaDevtools() haven't been called yet, we buffer the pending stores and once the devtools are registered, we add the store to the devtools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1063
Turned out in nuxt plugin environment,
pinia._ais not yet defined which resulted in devtools unable to find app record.