Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): storeToRefs with nested refs #2659

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix(types): storeToRefs with nested refs #2659

merged 1 commit into from
Sep 26, 2024

Conversation

quiteeasy
Copy link
Contributor

@quiteeasy quiteeasy commented Apr 29, 2024 •
edited
Loading

Close #2658

Fix: Return type of storeToRefs doesn't match runtime result if values are nested computed values #2658

@netlify Netlify
Copy link

netlify bot commented Apr 29, 2024 •
edited
Loading

✅ Deploy Preview for pinia-playground ready!

Name Link
🔨 Latest commit 2b1b80a
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/662fe3ffb407320007aaca3a
😎 Deploy Preview https://deploy-preview-2659--pinia-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 29, 2024 •
edited
Loading

✅ Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit 2b1b80a
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/662fe3ff16fcd90008f84245

@quiteeasy quiteeasy mentioned this pull request Apr 29, 2024
Closed
@posva posva changed the title fix: #2658 fix(types): storeToRefs with nested refs Jul 26, 2024
posva
posva requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
After updating locally and adding a test, it doesn't seem to be fixed 🤔
can you rebase from v2 branch and add a test to ensure this works?

@coderwei99
Copy link

coderwei99 commented Sep 14, 2024 •
edited
Loading

image

This pr looks fine
I can take additional tests if needed

posva
posva approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally again and it works. Thanks!

@posva posva merged commit 623e5a0 into vuejs:v2 Sep 26, 2024
4 checks passed
@Flashantik Flashantik mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pinia Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return type of storeToRefs doesn't match runtime result if values are nested computed values
3 participants
@quiteeasy @coderwei99 @posva