Update dependencies and compatibility tests (#1341)

* Update lockfile

`yarn install` was failing with newer node versions (>=10) because the
version of fsevents was too old (no precompiled binaries), and node-gyp
would fail to build it.

`yarn upgrade` mitigates this issue, but a change in `prettier` 1.18
(https://prettier.io/blog/2019/06/06/1.18.0.html) required `yarn format`
to also be run.

A missing dependency (`rollup-plugin-json`) was added to
`@vue/test-utils`, as it is imported in its build script.

* Update compatibility test versions

Update minor versions of running `yarn test:compat` to the latest patch
revisions.

Add optional argument to `yarn test:compat`, to allow running tests
against arbitrary `vue` versions.

Run compatibility tests in reverse order, to ensure the most relevant
test failures are displayed.

Run `yarn add` non-interactively, to force errors if `yarn test:compat`
is passed an invalid value.

Run `yarn add` without clobbering the lockfile.

* Update CircleCI config for compatibility tests

Having each compatibility test version specified in both the CI config
and the package script leads to inconsistencies over time. The CI config
can just use the package script.

* Hoist dev dependencies explicitly

Common build dependencies across sub-packages can get out-of-sync over
time. Currently, `rollup` and plugins is used across both `test-utils`
and `server-test-utils`, but different versions are specified. This
requires duplicate installations, and prevents hoisting.

Since `devDependencies` are not present in published packages, and since
the monorepo is used exclusively for building the subpackages, it makes
sense to define all build dependencies in the root package.

Move all `devDependencies` in the root package to `dependencies`, to
avoid unmet peer dependency errors in `yarn`:
yarnpkg/yarn#5810

Update each of these dependencies to their latest version, in particular
`rollup`, which has since released stable versions.

See https://github.com/lerna/lerna/blob/master/doc/hoist.md#lerna-hoisting

* Remove build step from compatibility tests

Each compatibility test installs a legacy version of `vue`, and builds
each package against this version before running the test suites. This
is assumedly in error, as the only build that gets published is the one
built against the dependencies in the lockfile.

To properly test compatibility for consumers using older versions of
`vue` to satisfy each package's peer dependency, we need to test against
the build that would actually get published. The fix is to run `yarn
build:test` only once, before any compatibility tests are run.

* Relax rollup dependency constraints

The upgrade from `rollup` beta -> stable went without breakages, so
clearly we don't need to overly constrain updated dependencies using the
`^` semver specifier.

* Revert locked dependencies

The updates from 1d6950a have to be partially reverted to allow for the
last compatiblity test suite to pass: `[email protected]`. There is some unclear
combination of dependencies that causes 80 unit test failures for only
the 2.0 version of vue.

Author: vvanpo

.circleci/config.yml

@@ -60,48 +60,13 @@ jobs:
       - run:
           name: yarn test
           command: yarn test
-  test_version_2.0.8:
+  test_compat:
     <<: *defaults
     steps:
       - attach_workspace:
           at: ~/repo
       - *restore_node_modules
-      - run: yarn test:compat "2.0.8"
-  test_version_2.1.10:
-    <<: *defaults
-    steps:
-      - attach_workspace:
-          at: ~/repo
-      - *restore_node_modules
-      - run: yarn test:compat "2.1.10"
-  test_version_2.2.6:
-    <<: *defaults
-    steps:
-      - attach_workspace:
-          at: ~/repo
-      - *restore_node_modules
-      - run: yarn test:compat "2.2.6"
-  test_version_2.3.4:
-    <<: *defaults
-    steps:
-      - attach_workspace:
-          at: ~/repo
-      - *restore_node_modules
-      - run: yarn test:compat "2.3.4"
-  test_version_2.4.2:
-    <<: *defaults
-    steps:
-      - attach_workspace:
-          at: ~/repo
-      - *restore_node_modules
-      - run: yarn test:compat "2.4.2"
-  test_version_2.5.13:
-    <<: *defaults
-    steps:
-      - attach_workspace:
-          at: ~/repo
-      - *restore_node_modules
-      - run: yarn test:compat "2.5.16"
+      - run: yarn test:compat
 workflows:
   version: 2
   install-tests:
@@ -116,32 +81,7 @@ workflows:
       - test:
           requires:
             - install
-      - test_version_2.0.8:
-          requires:
-            - install
-            - build_test
-            - test
-      - test_version_2.1.10:
-          requires:
-            - install
-            - build_test
-            - test
-      - test_version_2.2.6:
-          requires:
-            - install
-            - build_test
-            - test
-      - test_version_2.3.4:
-          requires:
-            - install
-            - build_test
-            - test
-      - test_version_2.4.2:
-          requires:
-            - install
-            - build_test
-            - test
-      - test_version_2.5.13:
+      - test_compat:
           requires:
             - install
             - build_test

package.json

@@ -20,16 +20,17 @@
     "format:check": "prettier --check \"**/*.{js,json,vue,md}\"",
     "release": "npm run build && npm run test:unit:only && lerna publish --conventional-commits -m \"chore(release): publish %s\" --cd-version prerelease",
     "test": "npm run format:check && npm run lint && npm run lint:docs && npm run flow && npm run test:types && npm run test:unit && npm run test:unit:karma && npm run test:unit:node",
-    "test:compat": "scripts/test-compat-all.sh",
+    "test:compat": "scripts/test-compat.sh",
     "test:unit": "npm run build:test && npm run test:unit:only",
     "test:unit:only": "mocha-webpack --webpack-config test/setup/webpack.test.config.js test/specs --recursive --require test/setup/mocha.setup.js",
     "test:unit:debug": "npm run build:test && node --inspect-brk node_modules/.bin/mocha-webpack --webpack-config test/setup/webpack.test.config.js test/specs --recursive --require test/setup/mocha.setup.js",
-    "test:unit:karma": "npm run build:test && TARGET=browser karma start test/setup/karma.conf.js --single-run",
+    "test:unit:karma": "npm run build:test && npm run test:unit:karma:only",
+    "test:unit:karma:only": "cross-env TARGET=browser karma start test/setup/karma.conf.js --single-run",
     "test:unit:node": "npm run build:test && npm run test:unit:node:only",
     "test:unit:node:only": "cross-env TEST_ENV=node mocha-webpack --webpack-config test/setup/webpack.test.config.js test/specs/render.spec.js test/specs/renderToString.spec.js --require test/setup/mocha.setup.js",
     "test:types": "tsc -p packages/test-utils/types && tsc -p packages/server-test-utils/types"
   },
-  "devDependencies": {
+  "dependencies": {
     "babel-core": "^6.26.0",
     "babel-eslint": "^8.2.2",
     "babel-loader": "^7.1.3",
@@ -41,7 +42,9 @@
     "babel-preset-flow-vue": "^1.0.0",
     "babel-preset-stage-2": "^6.24.1",
     "chai": "^4.0.0",
+    "chalk": "^2.4.2",
     "conditional-specs": "^1.0.1",
+    "conventional-changelog": "^3.1.12",
     "cross-env": "^5.0.0",
     "css-loader": "^0.28.4",
     "eslint": "^4.18.1",
@@ -63,10 +66,16 @@
     "mocha": "^5.2.0",
     "mocha-webpack": "^1.0.1",
     "prettier": "^1.16.0",
-    "rollup": "^0.58.2",
+    "rollup": "1",
+    "rollup-plugin-buble": "^0.19",
+    "rollup-plugin-commonjs": "10",
+    "rollup-plugin-flow-no-whitespace": "1",
+    "rollup-plugin-json": "4",
+    "rollup-plugin-node-resolve": "5",
+    "semver": "^6.3.0",
     "sinon": "^7.2.3",
     "sinon-chai": "^3.3.0",
-    "typescript": "^3.0.1",
+    "typescript": "3",
     "vee-validate": "^2.1.3",
     "vue": "^2.5.22",
     "vue-class-component": "^6.1.2",

packages/server-test-utils/package.json

@@ -27,17 +27,6 @@
     "cheerio": "^1.0.0-rc.2",
     "@types/cheerio": "^0.22.10"
   },
-  "devDependencies": {
-    "chalk": "^2.1.0",
-    "conventional-changelog": "^1.1.3",
-    "rollup": "^0.57.1",
-    "rollup-plugin-buble": "^0.19.2",
-    "rollup-plugin-commonjs": "^8.3.0",
-    "rollup-plugin-flow-no-whitespace": "^1.0.0",
-    "rollup-plugin-json": "^2.3.0",
-    "rollup-plugin-node-resolve": "^3.0.3",
-    "typescript": "^2.6.2"
-  },
   "peerDependencies": {
     "@vue/test-utils": "*",
     "vue": "2.x",

packages/shared/package.json

@@ -2,9 +2,6 @@
   "name": "shared",
   "version": "1.0.0-beta.29",
   "private": true,
-  "dependencies": {
-    "semver": "^5.6.0"
-  },
   "peerDependencies": {
     "vue": "2.x",
     "vue-template-compiler": "^2.x"

packages/test-utils/package.json

@@ -23,16 +23,6 @@
     "url": "https://github.com/vuejs/vue-test-utils/issues"
   },
   "homepage": "https://github.com/vuejs/vue-test-utils#readme",
-  "devDependencies": {
-    "chalk": "^2.1.0",
-    "conventional-changelog": "^1.1.3",
-    "rollup": "^0.56.3",
-    "rollup-plugin-buble": "^0.19.2",
-    "rollup-plugin-commonjs": "^8.3.0",
-    "rollup-plugin-flow-no-whitespace": "^1.0.0",
-    "rollup-plugin-node-resolve": "^3.0.3",
-    "typescript": "^2.6.2"
-  },
   "peerDependencies": {
     "vue": "2.x",
     "vue-template-compiler": "^2.x"