Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: basic implementation of v-memo for dom #23

Closed
wants to merge 3 commits into from
Closed

feat: basic implementation of v-memo for dom #23

wants to merge 3 commits into from

Conversation

baiwusanyu-c
Copy link
Member

@baiwusanyu-c baiwusanyu-c commented Nov 30, 2023 •
edited
Loading

close: #18

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 87.9 kB 33.4 kB 30.2 kB
runtime-vapor.global.prod.js 19.7 kB (+3.23 kB) 7.56 kB (+1.34 kB) 6.94 kB (+1.23 kB)
vue-vapor.global.prod.js 54.1 kB (+4.1 kB) 18.4 kB (+1.62 kB) 16.7 kB (+1.46 kB)
vue.global.prod.js 145 kB 52.5 kB 47 kB

Usages

Name Size Gzip Brotli
createApp 48.6 kB 19 kB 17.4 kB
createSSRApp 51.8 kB 20.3 kB 18.6 kB
defineCustomElement 50.9 kB 19.8 kB 18.1 kB
vapor 19.9 kB (+3.51 kB) 7.71 kB (+1.49 kB) 7.08 kB (+1.35 kB)
overall 61.9 kB 23.9 kB 21.8 kB

@autofix-troubleshooter
Copy link

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@baiwusanyu-c
Copy link
Member Author

There are too many conflicts, I am going to rewrite it

@sxzz
Copy link
Member

sxzz commented Dec 5, 2023

At the early stage, we think v-memo should be on hold for now.

@baiwusanyu-c baiwusanyu-c marked this pull request as draft December 5, 2023 08:58
@sxzz sxzz force-pushed the main branch 2 times, most recently from 2f9e25d to 0255505 Compare January 25, 2024 09:00
@sxzz sxzz force-pushed the main branch 9 times, most recently from 8605d92 to 8a2a2ac Compare February 10, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleSound LittleSound LittleSound left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v-memo
4 participants
@baiwusanyu-c @autofix-troubleshooter @sxzz @LittleSound