Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-search: Pressing the Enter key to finalize the converted text will cause a unintended page transition #2850

Open
1 task done
piyoppi opened this issue May 12, 2021 · 1 comment · May be fixed by #2851
Open
1 task done

Comments

@piyoppi
Copy link

piyoppi commented May 12, 2021

  • I confirm that this is an issue rather than a question.

Bug report

When typing a text in the search box and pressing Enter to convert it, the active suggestion is selected, causing an unintended page transition.
(In Japanese input, we often use the Enter key to confirm a character conversion.)

This issue was occered in a MacOS browsers (Chrome, Firefox). It was not reproduced in Windows OS.

Steps to reproduce

I add markdown file written in Japanese. https://github.com/piyoppi/vuepress/tree/demo-plugin-search-with-ime/packages/docs/docs/demo-for-japanese-input

It is including in the following branch. You can reproduce it by entering Japanese text (e.g. "タイトル") in the search box.

https://github.com/piyoppi/vuepress/tree/demo-plugin-search-with-ime

What is expected?

vuepress-expected

Pressing the Enter key to finalize the converted text will not cause a page transition.

What is actually happening?

vuepress-actual

Pressing the Enter key to finalize the converted text will cause a page transition.

Other relevant information

  • Output of npx vuepress info in my VuePress project:
@piyoppi
Copy link
Author

piyoppi commented May 12, 2021

I tried to fix the issue using Implicit submission of Form.

piyoppi@89f26c6

I am going to submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant