Rename ES7 docker image service to match existing ES config #523
Conversation
|
Because the docker-compose.nodejs.yml file depends on a container called I only decided to rename it to match the already existing ES v5 container, so it's easy to change between them. |
jahvi
force-pushed
the
elasticsearch7-config-fix
branch
from
24b5436 to
df80569
Compare
jahvi
force-pushed
the
elasticsearch7-config-fix
branch
from
df80569 to
4efb4c2
Compare
|
@Fifciu No problem, should be fixed now. |
| @@ -1,12 +1,12 @@ | |||
| version: '3.0' | |||
| services: | |||
| es7: | |||
| container_name: es7 | |||
| es1: | |||
There was a problem hiding this comment.
Doesn't this is in conflict for people that my want to run both at the same time as an migration step? So es5 and es7.
There was a problem hiding this comment.
That's true, however you can still start/stop the containers when testing
both.
With the current approach you need to change the container names in the
docker files and rebuild them so there's an extra step there.
The default docker setup expects the ES container to be named
elasticsearchso this should fix the issue where the API cannot connect to the ES server. I also renamed the service node toes1es that's the name the docker-compose.nodejs.yml depends on.Fixes #509