Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal Review preparation #652

Open
5 tasks
wseltzer opened this issue Sep 16, 2024 · 22 comments
Open
5 tasks

Horizontal Review preparation #652

wseltzer opened this issue Sep 16, 2024 · 22 comments

Comments

@wseltzer
Copy link
Collaborator

Per the W3C Process, we are required to get horizontal review: Accessibility, Architecture, Internationalization, Privacy, and Security. W3C Guidance: How to Get Horizontal Review.

This issue is meant to help us track overall progress.

Accessibility

Architecture

Internationalization

Privacy

Security

@wseltzer
Copy link
Collaborator Author

For each review area, I suggest the group find an internal champion to work with the relevant questionnaires and github issues to coordinate with the horizontal review group.

@wseltzer wseltzer added the agenda+ Regular CG meeting agenda items label Sep 16, 2024
@wseltzer
Copy link
Collaborator Author

Thanks for volunteering!

@hlflanagan
Copy link
Contributor

The i18n review request has been submitted. Results will be posted here: w3c/i18n-request#246

@philsmart
Copy link
Contributor

@npm1 and I are going to take a pass at the existing security and privacy questionnaire answers which I put into a Google Doc for easy editing: https://docs.google.com/document/d/1f-PUqW2uwxC4XQLtebhOixeRx3XShf5BzZ1ll3jLAOI/edit?usp=sharing

@philsmart
Copy link
Contributor

@npm1 and I are now happy with the answers in that Google Docs. @wseltzer I guess the next steps are to check through the Security section of the spec, and then we can request a review on GitHub.

@philsmart
Copy link
Contributor

I've not had a chance to look at the security review for 3 weeks. I will go back to coordinating #685 (or finalising that security section of the spec) with @npm1 .

@npm1
Copy link
Collaborator

npm1 commented Jan 8, 2025

I've not had a chance to look at the security review for 3 weeks. I will go back to coordinating #685 (or finalising that security section of the spec) with @npm1 .

Do you want to take a stab at sending a spec PR to do these changes and I can review it? Or should we do the other way around: I can send a spec PR and you can provide feedback.

@philsmart
Copy link
Contributor

philsmart commented Jan 9, 2025

@npm1 I am happy to provide a PR that helps define the structure as suggested by @simoneonofri (which we can take from w3c/vibration#49) and adds a starter for the 'Credential Leakage' threat. But really it would need your expertise to define/finalise the content anyway, so maybe it is best for me to review your PR.

*But still happy to do some of the early work in a branch if you thought useful.

@npm1
Copy link
Collaborator

npm1 commented Jan 16, 2025

Wrote #692 for security

@philsmart
Copy link
Contributor

Wrote #692 for security

Thank you. I will hopefully review by next Tuesday's FedID call.

@philsmart
Copy link
Contributor

Thanks to @npm1, there has been significant progress on the Security Considerations of the specification, see #692. I would also like to thank @TallTed and @simoneonofri for their comments and suggestions for improvement. After addressing @simoneonofri's's comments and merging the PR, we can proceed to a broader review.

@philsmart
Copy link
Contributor

The changes to the Security Considerations section have been merged. I will go figure out the next steps.

@simoneonofri
Copy link
Contributor

The changes to the Security Considerations section have been merged. I will go figure out the next steps.

@philsmart next step is to compile this https://www.w3.org/TR/security-privacy-questionnaire/ and request the review via GitHub

@npm1
Copy link
Collaborator

npm1 commented Feb 19, 2025

We already did that questionnaire https://github.com/w3c-fedid/FedCM/blob/main/privacy_questionnaire.md. It appears slightly updated though, shouldn't it have some indication about which questions are new?

@simoneonofri
Copy link
Contributor

We already did that questionnaire https://github.com/w3c-fedid/FedCM/blob/main/privacy_questionnaire.md. It appears slightly updated though, shouldn't it have some indication about which questions are new?

Good! I think at least the "15. Due to the new commits, does this specification have both "Security Considerations" and "Privacy Considerations" sections.

@philsmart
Copy link
Contributor

philsmart commented Feb 25, 2025

@npm1 I've taken a look through the Google Docs version and updated the section/question titles (where appropriate) based on the latest Security And Privacy Questionnaire from the 12th of Feb 2025. There are 5 new questions, arguably an answer to one of the previous questions (18) works for 2 of them (18 and 19). These are highlighted in the document (and are listed below):

5. Does data exposed by your specification carry related but distinct information that may not be obvious to users?
18. What happens when a document that uses your feature is kept alive in BFCache (instead of getting destroyed) after navigation, and potentially gets reused on future navigations back to the document?
19. What happens when a document that uses your feature gets disconnected?
20. Does your spec define when and how new kinds of errors should be raised?
21. Does your feature allow sites to learn about the user’s use of assistive technology?

@npm1
Copy link
Collaborator

npm1 commented Mar 12, 2025

Thanks Phil, I updated the doc. What's next?

@philsmart
Copy link
Contributor

Many thanks. I think we are in a position to request a review. I'll go through that process tomorrow and let you know.

@wseltzer
Copy link
Collaborator Author

Discussed in 11 March meeting.
Still looking for an internal champion to lead the accessibility self-review.

@philsmart
Copy link
Contributor

philsmart commented Mar 14, 2025

Sorry, @npm1. I forgot that https://github.com/w3c-fedid/FedCM/blob/main/privacy_questionnaire.md needed updating. I've created a markdown gist from the Google docs so you can hopefully just cut and paste that in. (I did not create a PR as it is not my work). I'll delete the Gist when done.

I will request a review on Tuesday of next week.

npm1 added a commit that referenced this issue Mar 18, 2025
npm1 added a commit that referenced this issue Mar 18, 2025
@philsmart
Copy link
Contributor

Thanks for updating @npm1, I've now requested a review: w3c/security-request#84.

@wseltzer
Copy link
Collaborator Author

Discussed March 11. Thanks @kedruff for offering to help with a11y self-review!

@wseltzer wseltzer removed the agenda+ Regular CG meeting agenda items label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants