Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login_url not documented in Section 3.2 #697

Open
togamid opened this issue Feb 9, 2025 · 3 comments
Open

login_url not documented in Section 3.2 #697

togamid opened this issue Feb 9, 2025 · 3 comments
Assignees

Comments

@togamid
Copy link

togamid commented Feb 9, 2025

The parameter "login_url" which is a required part of the response of the config endpoint according to section 2.2.5 is not mentioned in section 3.2, making the example in section 3.2 invalid.

The "login_url" should probably be added in section 3.2 unless there's a good reason to exclude it there.

@cbiesinger
Copy link
Collaborator

Yes, that was an oversight, thanks for letting us know!

@cbiesinger cbiesinger self-assigned this Feb 10, 2025
@cbiesinger cbiesinger changed the title login_url not dokumented in Section 3.2 login_url not documented in Section 3.2 Feb 10, 2025
@samuelgoto
Copy link
Collaborator

Yes, that was an oversight, thanks for letting us know!

+1!

@togamid any chance you'd be interested in sending a spec PR to fix this? We can get to this at some point, but if you are interested in trying, feel free to send a spec PR!

@togamid
Copy link
Author

togamid commented Feb 10, 2025

I can make the changes and create a PR in a few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants