Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip accounts_endpoint call when there's no chance of success #702

Open
ekovac opened this issue Feb 25, 2025 · 0 comments
Open

Skip accounts_endpoint call when there's no chance of success #702

ekovac opened this issue Feb 25, 2025 · 0 comments

Comments

@ekovac
Copy link

ekovac commented Feb 25, 2025

The accounts_endpoint should only be used if there's a chance of success that the request would be meaningfully authenticated. If there are no SameSite=None cookies for the IdP origin, we should skip it just as we would if the Login-Status for the origin is 'logged-out'.

Pros

  • Reduces network traffic
  • Reduces the need to wait for other IdP responses in the multi-IdP case, even if the user agent is seeing one of the IdPs for the first time (login-status is unknown.)

Cons

  • Would prevent IdP implementations from leveraging identifying information that the user agent isn't aware of, such as identity claim headers added by an Identity Aware VPN such as Tailscale.

Edit: Removed that this would break using, eg, Pomerium or other identity-aware reverse proxies, since there would be cookies for the reverse proxy origin. D'oh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant