-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review feedback wrt making spec more readable #213
Comments
The suggested changes to the abstract make a lot of sense to me. |
A lot of the comments seem to assign great importance to the filename, So "too detailed for an overview" is understandable but wrong. This is the whole spec, not just an overview. |
Earlier drafts talked about post-processing an original font for produce the subset font and the set of patches. That is one way, but not the only way. There might not be an original font at all (as an OpenType font); instead an font authoring tool might export an IFT-encoded OpenType font plus the set of patch files. So I think we are avoiding the term original font or whole font, except perhaps as an illustration of one workflow. |
In addition, since an IFT-encoded font is an OpenType font this means that:
so the authoring tool mentioned above might well export
and again, the OpenType IFT font might not actually exist as a separate entity |
Fair criticism. We overload the term incremental font, because the initial font file is an incremental font file, but also a partially-expanded font is also an incremental font file. And the initial font file is a font subset, but a non-incremental static subset is also a font subset. The difference is that one can be expanded and the other can not. We do define font subset. I think we should use that as the base definition, then define other terms from it: Static subset A font subset which cannot be expanded. Incremental font A font subset which, together with a set of patch files, can be expanded to produce a larger subset. Initial font An incremental font which constitutes the smallest subset. This is what a stylesheet links to. |
I see we also use fully expanded non-incremental font. And, sadly, the definition of font subset uses the term original font. I think we are asseting that fully expanded non-incremental font. is functionally identical to original font. Each time I read these introductory sections, I imagine diagrams in my head. The spec would be more readable if those diagrams existed. |
Per f2f at TPAC, Garret or Chris volunteered to review https://docs.google.com/document/d/1MAuXOJr7FQevxTg9NhaBOB5Y45Ak9Ad3SRyKDfND8SY/edit?usp=drivesdk and see if any edits made sense.
The text was updated successfully, but these errors were encountered: