Add a note about termination during activation. #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Activation handlers may not all get a chance to run, especially in the case of browser termination. A Service Worker should be designed to function properly, even if the activation handlers do not all complete successfully. Update Nightly and V1
|
I have never committed to a specification before, so I'm not 100% sure if this is the right format to add a Note, or if I added to the right place. Can make any suggested adjustments as needed. |
|
Sorry I missed this for over a month. This looks fine to me. @jakearchibald what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activation handlers may not all get a chance to run, especially in the
case of browser termination. A Service Worker should be designed to
function properly, even if the activation handlers do not all complete
successfully.
Update Nightly and V1
Closes #1372
Preview | Diff