Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dfns extraction: expand logic that skips imported definitions #1788

Closed
tidoust opened this issue Mar 6, 2025 · 0 comments · Fixed by #1789
Closed

Dfns extraction: expand logic that skips imported definitions #1788

tidoust opened this issue Mar 6, 2025 · 0 comments · Fixed by #1789

Comments

@tidoust
Copy link
Member

tidoust commented Mar 6, 2025

Via tc39/ecma426#174

The crawler skips "imported definitions", meaning those that some specs give a <dfn> to, but that are just a proxy to a definition in some other spec. That logic expects the markup of these imported definitions to be <dfn><a>foo</a></dfn>. The Ecmarkup tool seems to generate the opposite pattern: <a><dfn>foo</dfn></a>, which the crawler does not yet handle.
tidoust added a commit that referenced this issue Mar 6, 2025
@tidoust
Dfns extraction: expand logic that skips imported definitions
f6cd0c6 
The crawler expected "imported definitions" to use `<dfn>` as the wrapping
element with an inner `<a>` element. The Source map format spec now uses the
opposite pattern. This update expands the logic accordingly.

Close #1788.
@tidoust tidoust mentioned this issue Mar 6, 2025
Merged
@tidoust tidoust closed this as completed in 35d1671 Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dfns extraction: expand logic that skips imported definitions w3c/reffy
1 participant
@tidoust