Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pre-footer component should allow paragraphs or other kind of markups #646

Open
deniak opened this issue Jul 30, 2024 · 1 comment
Open
Assignees

Comments

@deniak
Copy link
Member

deniak commented Jul 30, 2024

Describe the issue
The pre-footer component is great to add additional content at the end of a page. However, it only seems to work with a list of <div>s containing a title and links, e.g.

<div>
    <h2 class="txt-jupiter">Keep updated</h2>
    <a href="mailto:[email protected]?subject=subscribe">Get press releases by email</a>
</div>
<div>
    <h2 class="txt-jupiter">Contact us</h2>
    <a href="mailto:[email protected]">Write to the W3C comms team</a>
</div>

This can be problematic if we want to use paragraphs or other tags because:

  1. the pre-footer children don't take all the space available. The width is limited for the selector .pre-footer.l-switcher > * > *
  2. all the links in the pre-footer have a display: block; causing them to be on separate lines (see below)
Screenshot 2024-07-30 at 19 13 44
@vivienlacourba
Copy link
Member

@NicolaSaunders to give you some context @deniak is working on creating a Jekyll theme based on the W3C design system that we will be use to style sub-sites relying on GitHub pages and a common need we identified is that while we would want to keep the main footer as is we would like to give sub-site owners the possibility to easily add content at the end of their pages within a "pre-footer".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

No branches or pull requests

3 participants