Rewview feedback

Author: chcunningham

samples/audio-video-player/audio_renderer.js

@@ -60,18 +60,6 @@ export class AudioRenderer {
     return promise;
   }
 
-  setVolume(volume) {
-    if (volume < 0.0 && volume > 1.0) {
-      return;
-    }
-    // Smooth exponential volume ramps on change
-    this.volume.gain.setTargetAtTime(
-      volume,
-      this.audioContext.currentTime,
-      0.3
-    );
-  }
-
   play() {
     // resolves when audio has effectively started: this can take some time if using
     // bluetooth, for example.
@@ -149,12 +137,12 @@ export class AudioRenderer {
     // Decode up to the buffering target or until decoder is saturated.
     while (usedBufferSecs < DATA_BUFFER_DECODE_TARGET_DURATION &&
       this.decoder.decodeQueueSize < DECODER_QUEUE_SIZE_MAX) {
-      debugLog(`\tmoar samples. usedBufferSecs:${usedBufferSecs} < target:${DATA_BUFFER_DECODE_TARGET_DURATION}.`);
+      debugLog(`\tMore samples. usedBufferSecs:${usedBufferSecs} < target:${DATA_BUFFER_DECODE_TARGET_DURATION}.`);
       let sample = await this.demuxer.readSample();
       this.decoder.decode(this.makeChunk(sample));
 
       // NOTE: awaiting the demuxer.readSample() above will also give the
-      // decoder output callbacka a chance to run, so we may see usedBufferSecs
+      // decoder output callbacks a chance to run, so we may see usedBufferSecs
       // increase.
       usedBufferElements = this.ringbuffer.capacity() - this.ringbuffer.available_write();
       usedBufferSecs = usedBufferElements / (this.channelCount * this.sampleRate);

samples/audio-video-player/audiosink.js

@@ -4,7 +4,9 @@ registerProcessor("AudioSink", class AudioSink extends AudioWorkletProcessor {
     let sab = options.processorOptions.sab;
     this.consumerSide = new RingBuffer(sab, Float32Array);
     this.mediaChannelCount = options.processorOptions.mediaChannelCount;
-    this.deinterleaveBuffer = new Float32Array(this.mediaChannelCount * 128);
+    // https://www.w3.org/TR/webaudio/#render-quantum-size
+    const RENDER_QUANTUM_SIZE = 128;
+    this.deinterleaveBuffer = new Float32Array(this.mediaChannelCount * RENDER_QUANTUM_SIZE);
     this.s = 0;
   }
 

samples/audio-video-player/mp4_pull_demuxer.js

@@ -17,38 +17,9 @@ export class MP4PullDemuxer {
   }
 
   getAvcDescription(avccBox) {
-    var i;
-    var size = 7;
-    for (i = 0; i < avccBox.SPS.length; i++) {
-      // nalu length is encoded as a uint16.
-      size+= 2 + avccBox.SPS[i].length;
-    }
-    for (i = 0; i < avccBox.PPS.length; i++) {
-      // nalu length is encoded as a uint16.
-      size+= 2 + avccBox.PPS[i].length;
-    }
-
-    var writer = new Writer(size);
-
-    writer.writeUint8(avccBox.configurationVersion);
-    writer.writeUint8(avccBox.AVCProfileIndication);
-    writer.writeUint8(avccBox.profile_compatibility);
-    writer.writeUint8(avccBox.AVCLevelIndication);
-    writer.writeUint8(avccBox.lengthSizeMinusOne + (63<<2));
-
-    writer.writeUint8(avccBox.nb_SPS_nalus + (7<<5));
-    for (i = 0; i < avccBox.SPS.length; i++) {
-      writer.writeUint16(avccBox.SPS[i].length);
-      writer.writeUint8Array(avccBox.SPS[i].nalu);
-    }
-
-    writer.writeUint8(avccBox.nb_PPS_nalus);
-    for (i = 0; i < avccBox.PPS.length; i++) {
-      writer.writeUint16(avccBox.PPS[i].length);
-      writer.writeUint8Array(avccBox.PPS[i].nalu);
-    }
-
-    return writer.getData();
+    const stream = new DataStream(undefined, 0, DataStream.BIG_ENDIAN);
+    avccBox.write(stream);
+    return new Uint8Array(stream.buffer, 8);  // Remove the box header.
   }
 
   async ready() {
@@ -218,37 +189,3 @@ class MP4Source {
     this._onSamples(samples);
   }
 }
-
-class Writer {
-  constructor(size) {
-    this.data = new Uint8Array(size);
-    this.idx = 0;
-    this.size = size;
-  }
-
-  getData() {
-    if(this.idx != this.size)
-      throw "Mismatch between size reserved and sized used"
-
-    return this.data.slice(0, this.idx);
-  }
-
-  writeUint8(value) {
-    this.data.set([value], this.idx);
-    this.idx++;
-  }
-
-  writeUint16(value) {
-    // TODO: find a more elegant solution to endianess.
-    var arr = new Uint16Array(1);
-    arr[0] = value;
-    var buffer = new Uint8Array(arr.buffer);
-    this.data.set([buffer[1], buffer[0]], this.idx);
-    this.idx +=2;
-  }
-
-  writeUint8Array(value) {
-    this.data.set(value, this.idx);
-    this.idx += value.length;
-  }
-}

samples/audio-video-player/server.js

@@ -16,16 +16,6 @@ const http = require('http'),
 const serverPort = parseInt(port, 10);
 
 http.createServer({}, function(request, response) {
-
-  // This server is insecure. Only listen for conncections on localhost.
-  if (request.headers.host != `localhost:${serverPort}`) {
-    console.log('Rejecting request for non-localhost');
-    response.writeHead(502, { "Content-Type": "text/plain" });
-    response.write("502 Connection Refused\n");
-    response.end();
-    return;
-  }
-
   var uri = url.parse(request.url).pathname,
     filename = path.join(process.cwd(), uri);
 
@@ -67,6 +57,8 @@ http.createServer({}, function(request, response) {
       response.end();
     });
   });
-}).listen(serverPort);
+
+// This server is insecure. Only listen for conncections on localhost.
+}).listen(serverPort, 'localhost');
 
 console.log("Static file server running at\n  => http://localhost:" + port + "/\nCTRL + C to shutdown");

samples/audio-video-player/video_renderer.js

@@ -80,11 +80,10 @@ export class VideoRenderer {
     if (frameIndex > 0)
       debugLog('dropping %d stale frames', frameIndex);
 
-
-      for (let i = 0; i < frameIndex; i++) {
-        let staleFrame = this.frameBuffer.shift();
-        staleFrame.close();
-      }
+    for (let i = 0; i < frameIndex; i++) {
+      let staleFrame = this.frameBuffer.shift();
+      staleFrame.close();
+    }
 
     let chosenFrame = this.frameBuffer[0];
     debugLog('frame time delta = %dms (%d vs %d)', minTimeDelta/1000, timestamp, chosenFrame.timestamp)

samples/audio-video-player/web_audio_controller.js

@@ -87,6 +87,4 @@ export class WebAudioController {
 
     return Math.max(this.audioContext.currentTime - totalOutputLatency, 0.0);
   }
-
-
-}
+}