Treat user code as a referenced project #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodic
force-pushed
the
filip-project-references
branch
from
3fd1830 to
4d3f95d
Compare
sodic
commented
Jan 17, 2025
infomiho
reviewed
Jan 20, 2025
| "vite.config.ts", | ||
| "./src/ext-src/vite.config.ts" | ||
| ] | ||
| } |
There was a problem hiding this comment.
This got fixed somewhere. Not sure where, but I see the file is now properly formatted on main.
| @@ -1,11 +1,18 @@ | |||
| // =============================== IMPORTANT ================================= | |||
There was a problem hiding this comment.
Idea for the future, I've love it if we could apply tsconfig fixes with Wasp CLI so users don't have to do it manually.
| @@ -20,6 +27,7 @@ | |||
| "dom.iterable", | |||
| "esnext" | |||
| ], | |||
| "skipLibCheck": true, | |||
There was a problem hiding this comment.
We added this option, but we validate it with anyValueIsFine so why add it at all?
sodic
commented
Jan 21, 2025
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2247