Move PackageJson to AppSpec
#2506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodic
commented
Feb 17, 2025
Comment on lines
+81
to
+83
| kebabToCamelCase kebabCaseStr = case wordsBy (== '-') kebabCaseStr of | ||
| [] -> "" | ||
| (firstWord : otherWords) -> concat $ firstWord : map toUpperFirst otherWords |
There was a problem hiding this comment.
Has nothing to do with the PR, but I couldn't resist.
infomiho
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this on my refactoring list.
PackageJsonis a part of theAppSpecbut was inExternalConfig, which meansAppSpecdepended onExternalConfig.I've reversed that, and now
AppSpecis the proper source of truth.If we went full enterprise, we'd have two different types and a validator: one for the AppSpec, one for the Parser, and a validator that maps one into the other. But I thought that was too much at this point.