remove telemetry, loosen up the "atBottom" check (50% of viewport)

Author: sawka

frontend/app/view/term/termwrap.ts

@@ -13,7 +13,6 @@ import {
     globalStore,
     isDev,
     openLink,
-    recordTEvent,
     setTabIndicator,
     WOS,
 } from "@/store/global";
@@ -561,34 +560,13 @@ export class TermWrap {
 
     handleViewportScroll(viewportElem: HTMLElement) {
         const { scrollTop, scrollHeight, clientHeight } = viewportElem;
-        const atBottom = scrollTop + clientHeight >= scrollHeight - 20;
+        const atBottom = scrollTop + clientHeight >= scrollHeight - clientHeight * 0.5;
         this.setAtBottom(atBottom);
-        const hasScrollback = scrollHeight > clientHeight + 20;
         const delta = this.viewportScrollTop - scrollTop;
-        const wasNearBottom = this.viewportScrollTop >= scrollHeight - clientHeight - 100;
-        const shouldSendTelemetry = scrollTop === 0 && hasScrollback && delta >= 1000;
-        if ((isDev() && delta >= 500) || shouldSendTelemetry) {
-            const lastCmd = globalStore.get(this.lastCommandAtom) ?? "";
-            let termCmd = "";
-            if (/^claude\b/.test(lastCmd)) {
-                termCmd = "claude";
-            } else if (/^opencode\b/.test(lastCmd)) {
-                termCmd = "opencode";
-            }
-            if (isDev() && delta >= 500) {
-                console.log(
-                    `[termwrap] large-scroll blockId=${this.blockId} delta=${Math.round(delta)}px scrollTop=${scrollTop} wasNearBottom=${wasNearBottom} termCmd=${termCmd || "(none)"} sendTelemetry=${shouldSendTelemetry}`
-                );
-                console.log("[termwrap] recentWrites (last 50):", this.recentWrites);
-                console.trace("[termwrap] large-scroll callstack");
-            }
-            if (shouldSendTelemetry) {
-                recordTEvent("debug:termscrolltop", {
-                    "debug:scrollpx": Math.round(delta),
-                    "debug:scrollfrombot": wasNearBottom,
-                    "debug:termcmd": termCmd || undefined,
-                });
-            }
+        if (isDev() && delta >= 500) {
+            console.log(
+                `[termwrap] large-scroll blockId=${this.blockId} delta=${Math.round(delta)}px scrollTop=${scrollTop} wasNearBottom=${atBottom}`
+            );
         }
         this.viewportScrollTop = scrollTop;
     }

frontend/types/gotypes.d.ts

@@ -1469,9 +1469,6 @@ declare global {
         "action:initiator"?: "keyboard" | "mouse";
         "action:type"?: string;
         "debug:panictype"?: string;
-        "debug:scrollpx"?: number;
-        "debug:scrollfrombot"?: boolean;
-        "debug:termcmd"?: string;
         "block:view"?: string;
         "block:controller"?: string;
         "ai:backendtype"?: string;

pkg/telemetry/telemetrydata/telemetrydata.go

@@ -32,8 +32,7 @@ var ValidEventNames = map[string]bool{
 
 	"wsh:run": true,
 
-	"debug:panic":          true,
-	"debug:termscrolltop":  true,
+	"debug:panic": true,
 
 	"conn:connect":      true,
 	"conn:connecterror": true,
@@ -116,10 +115,7 @@ type TEventProps struct {
 	ActionInitiator string `json:"action:initiator,omitempty" tstype:"\"keyboard\" | \"mouse\""`
 	ActionType      string `json:"action:type,omitempty"`
 
-	PanicType          string `json:"debug:panictype,omitempty"`
-	DebugScrollPx      int    `json:"debug:scrollpx,omitempty"`
-	DebugScrollFromBot bool   `json:"debug:scrollfrombot,omitempty"`
-	DebugTermCmd       string `json:"debug:termcmd,omitempty"`
+	PanicType string `json:"debug:panictype,omitempty"`
 
 	BlockView       string `json:"block:view,omitempty"`
 	BlockController string `json:"block:controller,omitempty"`
@@ -130,11 +126,11 @@ type TEventProps struct {
 	WshCmd      string `json:"wsh:cmd,omitempty"`
 	WshHadError bool   `json:"wsh:haderror,omitempty"`
 
-	ConnType          string `json:"conn:conntype,omitempty"`
-	ConnWshErrorCode  string `json:"conn:wsherrorcode,omitempty"`
-	ConnErrorCode     string `json:"conn:errorcode,omitempty"`
-	ConnSubErrorCode  string `json:"conn:suberrorcode,omitempty"`
-	ConnContextError  bool   `json:"conn:contexterror,omitempty"`
+	ConnType         string `json:"conn:conntype,omitempty"`
+	ConnWshErrorCode string `json:"conn:wsherrorcode,omitempty"`
+	ConnErrorCode    string `json:"conn:errorcode,omitempty"`
+	ConnSubErrorCode string `json:"conn:suberrorcode,omitempty"`
+	ConnContextError bool   `json:"conn:contexterror,omitempty"`
 
 	OnboardingFeature    string `json:"onboarding:feature,omitempty" tstype:"\"waveai\" | \"durable\" | \"magnify\" | \"wsh\""`
 	OnboardingVersion    string `json:"onboarding:version,omitempty"`