Skip to content

Commit 6c8df20

Browse files
Copilotsawka
andauthored
Remove ellipsis mixin and delete mixins.scss (#2480)
The `ellipsis()` mixin in `mixins.scss` was only used in two files. Replaced with plain CSS and removed the file entirely. ## Changes - **Converted mixin usage to plain CSS** in `flyoutmenu.scss` and `expandablemenu.scss`: ```scss // Before .label { @include mixins.ellipsis(); } // After .label { display: block; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; } ``` - **Removed unused imports** from 8 SCSS files that imported `mixins.scss` but didn't use it - **Deleted** `frontend/app/mixins.scss` <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > in mixins.scss we have one last one called ellipsis(). i believe it is only used in a couple places now... at least flyoutmenu.scss and expandablemenu.scss. lets convert those to just plain CSS instead of using the mixin. and then i think we can delete the mixins.scss file completely... maybe 8 or so scss files that include it that will also need modification. > > do your own check though to find any additional usages of mixins.scss and the ellipsis mixin. make sure we remove all usages. </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: sawka <[email protected]>
1 parent 4df6dfd commit 6c8df20

File tree

9 files changed

+8
-27
lines changed

9 files changed

+8
-27
lines changed

frontend/app/block/block.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright 2024, Command Line Inc.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
@use "../mixins.scss";
5-
64
.block {
75
display: flex;
86
flex-direction: column;

frontend/app/element/button.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright 2024, Command Line Inc.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
@use "../mixins.scss";
5-
64
.wave-button {
75
// override default button appearance
86
border: 1px solid transparent;

frontend/app/element/expandablemenu.scss

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright 2024, Command Line Inc.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
@use "../mixins.scss";
5-
64
.expandable-menu {
75
display: flex;
86
flex-direction: column;
@@ -20,7 +18,10 @@
2018
border-radius: 4px;
2119

2220
.label {
23-
@include mixins.ellipsis();
21+
display: block;
22+
white-space: nowrap;
23+
overflow: hidden;
24+
text-overflow: ellipsis;
2425
}
2526
}
2627

frontend/app/element/flyoutmenu.scss

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright 2024, Command Line Inc.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
@use "../mixins.scss";
5-
64
.menu {
75
position: absolute;
86
z-index: 1000;
@@ -36,7 +34,10 @@
3634
border-radius: 2px;
3735

3836
.label {
39-
@include mixins.ellipsis();
37+
display: block;
38+
white-space: nowrap;
39+
overflow: hidden;
40+
text-overflow: ellipsis;
4041
text-decoration: none;
4142
}
4243
}

frontend/app/element/input.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright 2024, Command Line Inc.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
@use "../mixins.scss";
5-
64
.input {
75
width: 100%;
86
border: none;

frontend/app/mixins.scss

Lines changed: 0 additions & 9 deletions
This file was deleted.

frontend/app/modals/typeaheadmodal.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright 2024, Command Line Inc.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
@use "../mixins.scss";
5-
64
.type-ahead-modal-backdrop {
75
position: absolute;
86
top: 0;

frontend/app/view/preview/csvview.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright 2024, Command Line Inc.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
@use "../../mixins.scss";
5-
64
.csv-view {
75
opacity: 0; /* Start with an opacity of 0, meaning it's invisible */
86

frontend/app/view/preview/directorypreview.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright 2024, Command Line Inc.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
@use "../../mixins.scss";
5-
64
.dir-table-container {
75
display: flex;
86
flex-direction: column;

0 commit comments

Comments
 (0)