Skip to content

DS Drift Patrol — week of 2026-05-19 (merged-to-main violations) #1978

@sure-design

Description

@sure-design

DS Drift Patrol — 1 finding (merged to main, week of 2026-05-19)

Scan date: 2026-05-25 · Diff-scope only (added + lines in non-DS-source files) · Commits: 2026-05-18 → 2026-05-25


Rule 1 — Hand-rolled pill/badge bypassing DS::Pill

Commit adea16ffix(views): clear Rule 2 + Rule 5 findings from weekly DS drift (#1951) (#1955)
File: app/views/admin/users/index.html.erb

+  <span class="inline-flex items-center px-2 py-0.5 rounded text-xs font-medium bg-success/10 text-success shrink-0">

This commit fixed existing DS drift violations but introduced a new hand-rolled badge span. The pattern (inline-flex items-center px-2 py-0.5 rounded text-xs font-medium + semantic color) is exactly the shape DS::Pill covers.

➜ Replace with:

<%= render DS::Pill.new(label: "...", tone: :success) %>

(Adjust tone: and label: as needed; DS::Pill badge-mode + semantic tones are available after #1902.)


Coverage notes

  • 26 open PRs scanned for UI-touching diffs; 6 had violations (reported directly on those PRs).
  • 50 merged commits scanned; 1 net violation above (a text-white instance in 78c3331360ca was fixed the same week by 834ec19fdc45, netting clean).

Generated by Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions