Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Favicon setting in html plugin does not work correctly when output.publicPath: "auto" #8412

Open
mochiya98 opened this issue Nov 12, 2024 · 0 comments · May be fixed by #8415
Open

[Bug]: Favicon setting in html plugin does not work correctly when output.publicPath: "auto" #8412

mochiya98 opened this issue Nov 12, 2024 · 0 comments · May be fixed by #8415
Labels
bug Something isn't working pending triage The issue/PR is currently untouched.

Comments

@mochiya98
Copy link

System Info

System Info
  System:
    OS: macOS 15.0
    CPU: (11) arm64 Apple M3 Pro
    Memory: 57.17 MB / 18.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 20.15.0 - ~/.anyenv/envs/nodenv/versions/20.15.0/bin/node
    Yarn: 1.22.22 - ~/.anyenv/envs/nodenv/versions/20.15.0/bin/yarn
    npm: 10.7.0 - ~/.anyenv/envs/nodenv/versions/20.15.0/bin/npm
    pnpm: 9.12.3 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 130.0.6723.117
    Edge: 130.0.2849.80
    Safari: 18.0
  npmPackages:
    @rspack/cli: ^1.1.0 => 1.1.0 
    @rspack/core: ^1.1.0 => 1.1.0 
    @rspack/plugin-react-refresh: 1.0.0 => 1.0.0 

Details

when output.publicPath:“auto”, the html plugin outputs the following tag:

<link href="dist/favicon.svg" rel="icon" />

but it should be as follows:

<link href="favicon.svg" rel="icon" />

Reproduce link

No response

Reproduce Steps

config like this:

{
  output: {
    publicPath: "auto"
  },
  plugins: [
    new rspack.HtmlRspackPlugin({
      favicon: "./src/favicon.svg",
    })
  ]
}
@mochiya98 mochiya98 added bug Something isn't working pending triage The issue/PR is currently untouched. labels Nov 12, 2024
@inottn inottn linked a pull request Nov 12, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending triage The issue/PR is currently untouched.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant