Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we still need the merge_pr_* tags? #209

Open
gsnedders opened this issue Aug 26, 2024 · 0 comments
Open

Do we still need the merge_pr_* tags? #209

gsnedders opened this issue Aug 26, 2024 · 0 comments

Comments

@gsnedders
Copy link
Member

gsnedders commented Aug 26, 2024

Historically we had to have the merge_pr_* tags to have somewhere to put the generated manifests.

This isn't actually true any more, now that we're using GitHub Actions for them, as we can simply pull them down as workflow artifacts.

It's unclear whether https://docs.github.com/en/rest/actions/artifacts?apiVersion=2022-11-28#list-artifacts-for-a-repository alone suffices, as that doesn't have a defined sort order, or we can simply do what we do now and start querying commits to see if we have a workflow run for them.

It would be nice to clear out the 32927 merge_pr_* tags we currently have, as this is pretty noisy when pulling.

See also: #117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant