Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to handle exceptions thrown in testdriver #46624

Open
WeizhongX opened this issue Jun 4, 2024 · 6 comments
Open

how to handle exceptions thrown in testdriver #46624

WeizhongX opened this issue Jun 4, 2024 · 6 comments

Comments

@WeizhongX
Copy link
Contributor

There are some exceptions thrown in testdriver-extra.js [1]. As the exceptions are thrown inside the browser, will they cause test to fail

[1] https://source.chromium.org/search?q=f:third_party%2Fwpt_tools%2Fwpt%2Ftools%2Fwptrunner%2Fwptrunner%2Ftestdriver-extra.js%20%22throw%20new%22&ss=chromium%2Fchromium%2Fsrc

@WeizhongX
Copy link
Contributor Author

Background: this is brought up when we discuss a crashtest(html/semantics/popovers/popover-dialog-crash.html) that uses testdriver.js. The crashtest is show as passed on wpt.fyi.

@WeizhongX
Copy link
Contributor Author

@foolip @jgraham

@WeizhongX
Copy link
Contributor Author

Maybe the exception is ignored only when run crashtests, but as we do not care about success or failure for crash tests, this is not a problem?

@WeizhongX
Copy link
Contributor Author

@mfreed7 What is your opinion for my question in the above comment?

@jgraham
Copy link
Contributor

jgraham commented Sep 6, 2024

Note that crashtests currently aren't allowed to use testdriver and it won't work on the shared infra (unlike in Google's CI).

@WeizhongX
Copy link
Contributor Author

Note that crashtests currently aren't allowed to use testdriver and it won't work on the shared infra (unlike in Google's CI).

This is true. But I think we should eventually make testdriver work with both reftests and crashtests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants