From e4087f28c02093b891c937299c58926adaa574ed Mon Sep 17 00:00:00 2001 From: Rotzbua Date: Tue, 4 Feb 2025 21:31:52 +0100 Subject: [PATCH] feat(tests): use strict assert --- .php-cs-fixer.php | 1 + tests/SubscriptionTest.php | 12 ++++++------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php index 0b5827d..54579d4 100644 --- a/.php-cs-fixer.php +++ b/.php-cs-fixer.php @@ -8,6 +8,7 @@ 'blank_line_after_opening_tag' => false, // Do not waste space between ['import_classes' => false, 'import_constants' => false, 'import_functions' => false], 'php_unit_test_class_requires_covers' => true, + 'php_unit_construct' => true, 'php_unit_method_casing' => true, // Do not enable by default. These rules require review!! (but they are useful) // '@PHP80Migration:risky' => true, diff --git a/tests/SubscriptionTest.php b/tests/SubscriptionTest.php index 3e6b9a2..3c8fa98 100644 --- a/tests/SubscriptionTest.php +++ b/tests/SubscriptionTest.php @@ -14,18 +14,18 @@ public function testCreateMinimal(): void ]; $subscription = Subscription::create($subscriptionArray); $this->assertEquals("http://toto.com", $subscription->getEndpoint()); - $this->assertEquals(null, $subscription->getPublicKey()); - $this->assertEquals(null, $subscription->getAuthToken()); - $this->assertEquals(null, $subscription->getContentEncoding()); + $this->assertNull($subscription->getPublicKey()); + $this->assertNull($subscription->getAuthToken()); + $this->assertNull($subscription->getContentEncoding()); } public function testConstructMinimal(): void { $subscription = new Subscription("http://toto.com"); $this->assertEquals("http://toto.com", $subscription->getEndpoint()); - $this->assertEquals(null, $subscription->getPublicKey()); - $this->assertEquals(null, $subscription->getAuthToken()); - $this->assertEquals(null, $subscription->getContentEncoding()); + $this->assertNull($subscription->getPublicKey()); + $this->assertNull($subscription->getAuthToken()); + $this->assertNull($subscription->getContentEncoding()); } public function testCreatePartial(): void