Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Forge PNPM workaround #926

Open
goosewobbler opened this issue Feb 5, 2025 · 3 comments
Open

Remove Forge PNPM workaround #926

goosewobbler opened this issue Feb 5, 2025 · 3 comments
Assignees
@goosewobbler
Labels
backport-requested Should be applied to the maintained (previous) version blocked dependencies documentation Improvements or additions to documentation electron forge tooling
Milestone
9.0.0

Comments

@goosewobbler
Copy link
Member

Electron Forge doesn't support PNPM at all - which led to some exceedingly hacky approaches to things when reworking the repo into a full monorepo, specifically we are using Yarn to install Forge-related E2E packages and this effectively cripples our use of turborepo to streamline the build process.

Now that there's some light at the end of the tunnel, we should consider removing the workarounds, which in turn means we can greatly improve the efficiency of the build pipeline.
@goosewobbler goosewobbler added this to the 9.0.0 milestone Feb 5, 2025
@goosewobbler
Copy link
Member Author

Targetting v9, currently blocked pending the next Forge release which supports PNPM.

@goosewobbler goosewobbler added the backport-requested Should be applied to the maintained (previous) version label Feb 5, 2025
@goosewobbler goosewobbler self-assigned this Feb 5, 2025
@goosewobbler
Copy link
Member Author

goosewobbler commented Feb 7, 2025 •
edited
Loading

Looks like we will have a limitation here in that Forge will require node-linker=hoisted...

UPDATE: asked for some clarity around this in the Forge PNPM support PR. Though I suspect it will be a case of "see what works"

This was referenced Feb 7, 2025
Closed
Open
@goosewobbler
Copy link
Member Author

The Forge PR got merged, with exceptions for hoist-pattern and public-hoist-pattern at my request. Just waiting for the next release now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goosewobbler goosewobbler

Labels
backport-requested Should be applied to the maintained (previous) version blocked dependencies documentation Improvements or additions to documentation electron forge tooling
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
1 participant
@goosewobbler