Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test E2Es against packaged service instead of workspace link #955

Open
goosewobbler opened this issue Feb 14, 2025 · 0 comments · May be fixed by #956
Open

Test E2Es against packaged service instead of workspace link #955

goosewobbler opened this issue Feb 14, 2025 · 0 comments · May be fixed by #956
Assignees
Labels
backport-requested Should be applied to the maintained (previous) version CI tests
Milestone

Comments

@goosewobbler
Copy link
Member

goosewobbler commented Feb 14, 2025

Currently E2E tests use workspace links which can mask packaging issues that only appear in real installations. We should test against the packaged version of the service. Doing so will negate the need for manual testing with wdio-electron-service-example.

Approach:

  1. Create TestAppsManager to:

    • Package service with pnpm pack
    • Copy apps to temp dir
    • Replace workspace links with packaged service
    • Install dependencies
  2. Update test infrastructure:

    • Single preparation run
    • Proper temp directory cleanup
    • Update CI workflow

This will catch packaging and module resolution issues earlier by testing the service as users would consume it.

@goosewobbler goosewobbler self-assigned this Feb 14, 2025
@goosewobbler goosewobbler added this to the 8.x.y milestone Feb 14, 2025
@goosewobbler goosewobbler added the backport-requested Should be applied to the maintained (previous) version label Feb 14, 2025
@goosewobbler goosewobbler linked a pull request Feb 14, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested Should be applied to the maintained (previous) version CI tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant