Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge script is not using the current build tool #968

Open
mato533 opened this issue Feb 21, 2025 · 0 comments · May be fixed by #970
Open

Forge script is not using the current build tool #968

mato533 opened this issue Feb 21, 2025 · 0 comments · May be fixed by #970
Labels
bug Something isn't working CI electron forge

Comments

@mato533
Copy link
Contributor

mato533 commented Feb 21, 2025

Forge script is not using the current build tool because the forge script is replace the build script as follows.
The current script is running rollup only, this part of hack should be removed.

// update build scripts for yarn
shell.exec('pnpm pkg set scripts.build="yarn build:esm && yarn build:cjs"');
shell.exec('pnpm pkg set scripts.build:cjs="yarn build:cjs:copy && yarn build:cjs:compile"');

@mato533 mato533 added bug Something isn't working CI electron forge labels Feb 21, 2025
@mato533 mato533 linked a pull request Feb 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI electron forge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant