Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate issues running workbench.executeCommand("...") for VSCode in the browser #23

Open
christian-bromann opened this issue Jul 18, 2022 · 2 comments
Open

Investigate issues running workbench.executeCommand("...") for VSCode in the browser #23

christian-bromann opened this issue Jul 18, 2022 · 2 comments
Labels
help wanted Extra attention is needed vscode-web Issues related to testing web extensions

Comments

@christian-bromann
Copy link
Contributor

Running workbench.executeCommand("...") doesn't seem to work running VSCode for the browser. Let's investigate this and make it interoperable. This should also allow us to unskip some of the e2e tests.
@christian-bromann christian-bromann added help wanted Extra attention is needed vscode-web Issues related to testing web extensions labels Jul 18, 2022
@meguia-sfdc meguia-sfdc mentioned this issue Aug 18, 2022
Merged
@MaxKless
Copy link
Contributor

Not sure if this is related but I've been experiencing some weird issues with workbench.executeCommand as well, but not in the browser.
When using it to execute a vscode.openFolder command twice throughout a test suite, the second time never worked...
I ended up splitting my tests so I would never have to open two folders in them but it's still not ideal.

@seanpoulter
Copy link
Contributor

@MaxKless, your issue should be resolved in v6 by #106.
That doesn't address Christian's initial concern though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed vscode-web Issues related to testing web extensions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@christian-bromann @seanpoulter @MaxKless