Skip to content

Commit f9b63d2

Browse files
committed
Make all-storages response valid JSON with response model
1 parent c06e193 commit f9b63d2

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

backend/btrixcloud/models.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1155,6 +1155,13 @@ class OrgStorageReplicaRefs(BaseModel):
11551155
storageReplicas: List[StorageRef]
11561156

11571157

1158+
# ============================================================================
1159+
class OrgAllStorages(BaseModel):
1160+
"""Response model for listing all available storages"""
1161+
1162+
allStorages: List[StorageRef]
1163+
1164+
11581165
# ============================================================================
11591166
class S3StorageIn(BaseModel):
11601167
"""Custom S3 Storage input model"""

backend/btrixcloud/storages.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
OrgStorageRefs,
5050
OrgStorageRef,
5151
OrgStorageReplicaRefs,
52+
OrgAllStorages,
5253
DeletedResponse,
5354
UpdatedResponse,
5455
UpdatedResponseId,
@@ -387,14 +388,14 @@ async def _run_post_storage_replica_update_tasks(
387388
org, replica_storage, remove=True
388389
)
389390

390-
def get_available_storages(self, org: Organization) -> List[StorageRef]:
391+
def get_available_storages(self, org: Organization) -> Dict[str, List[StorageRef]]:
391392
"""return a list of available default + custom storages"""
392393
refs: List[StorageRef] = []
393394
for name in self.default_storages:
394395
refs.append(StorageRef(name=name, custom=False))
395396
for name in org.customStorages:
396397
refs.append(StorageRef(name=name, custom=True))
397-
return refs
398+
return {"allStorages": refs}
398399

399400
@asynccontextmanager
400401
async def get_s3_client(
@@ -893,7 +894,7 @@ def get_storage_refs(
893894
@router.get(
894895
"/all-storages",
895896
tags=["organizations", "storage"],
896-
response_model=List[StorageRef],
897+
response_model=OrgAllStorages,
897898
)
898899
def get_available_storages(org: Organization = Depends(org_owner_dep)):
899900
return storage_ops.get_available_storages(org)

0 commit comments

Comments
 (0)