You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A couple of Chromium projects need access to Windows features that are
only exposed in the 2428 point release of 10.0.22621. The previous
toolchain package used the 10.0.22621.755 (Windows 11 22H2) SDK. This
follows the same packaging steps but it pulls in the latest SDK, thus
giving access to the new features.
When we start depending on the new SDK then developers who don't use the
packaged toolchain will need to update their locally installed SDK. The
changes that add the dependencies on the new SDK will check for it and
give error messages to guide developers.
Packaging was done on a Windows 10 Hyper-V VM, cleanly created for this
purpose. Specifically, the Hyper-V Quick Create tool was used to create
a Windows 11 dev environment. VS Community Edition was then uninstalled.
Then the package was created by installing depot_tools, downloading the
VS Professional 2022 installer from https://visualstudio.microsoft.com/downloads/
(free trial, not preview) and then running the installer like this:
$ PATH_TO_INSTALLER.EXE ^
--add Microsoft.VisualStudio.Workload.NativeDesktop ^
--add Microsoft.VisualStudio.Component.VC.ATLMFC ^
--add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
--add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
--includeRecommended --passive
Then Add/Remove programs was used to modify the SDK to add the Debuggers
package.
Then the packaging script was run like this:
python3 depot_tools\win_toolchain\package_from_installed.py 2022 -w 10.0.22621.0
The packaging process was done on new VMs hosted on two different
machines to make sure that the results were consistent.
Updates were made to the comments and documentation, however very few
updates were needed because the SDK change is just a point release.
Bug: 40282717, 325004812
Change-Id: I6f59d07755db715974c1c4590d751e14b85a409d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5350823
Reviewed-by: Hans Wennborg <[email protected]>
Reviewed-by: Michael Tang <[email protected]>
Reviewed-by: Bruce Dawson <[email protected]>
Commit-Queue: Bruce Dawson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1273698}
NOKEYCHECK=True
GitOrigin-RevId: 7ff6e7df4cb828a32bcce61f454e3c08e5ae3654
0 commit comments