Skip to content

Commit 60e367e

Browse files
randomasciicopybara-github
authored andcommitted
New toolchain for Windows 11 10.0.22621.2428 SDK
A couple of Chromium projects need access to Windows features that are only exposed in the 2428 point release of 10.0.22621. The previous toolchain package used the 10.0.22621.755 (Windows 11 22H2) SDK. This follows the same packaging steps but it pulls in the latest SDK, thus giving access to the new features. When we start depending on the new SDK then developers who don't use the packaged toolchain will need to update their locally installed SDK. The changes that add the dependencies on the new SDK will check for it and give error messages to guide developers. Packaging was done on a Windows 10 Hyper-V VM, cleanly created for this purpose. Specifically, the Hyper-V Quick Create tool was used to create a Windows 11 dev environment. VS Community Edition was then uninstalled. Then the package was created by installing depot_tools, downloading the VS Professional 2022 installer from https://visualstudio.microsoft.com/downloads/ (free trial, not preview) and then running the installer like this: $ PATH_TO_INSTALLER.EXE ^ --add Microsoft.VisualStudio.Workload.NativeDesktop ^ --add Microsoft.VisualStudio.Component.VC.ATLMFC ^ --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^ --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^ --includeRecommended --passive Then Add/Remove programs was used to modify the SDK to add the Debuggers package. Then the packaging script was run like this: python3 depot_tools\win_toolchain\package_from_installed.py 2022 -w 10.0.22621.0 The packaging process was done on new VMs hosted on two different machines to make sure that the results were consistent. Updates were made to the comments and documentation, however very few updates were needed because the SDK change is just a point release. Bug: 40282717, 325004812 Change-Id: I6f59d07755db715974c1c4590d751e14b85a409d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5350823 Reviewed-by: Hans Wennborg <[email protected]> Reviewed-by: Michael Tang <[email protected]> Reviewed-by: Bruce Dawson <[email protected]> Commit-Queue: Bruce Dawson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1273698} NOKEYCHECK=True GitOrigin-RevId: 7ff6e7df4cb828a32bcce61f454e3c08e5ae3654
1 parent d7c0d9a commit 60e367e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

vs_toolchain.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
from gn_helpers import ToGNString
1919

20-
# VS 2022 17.4 with 10.0.22621.0 SDK with ARM64 libraries and UWP support.
20+
# VS 2022 17.9.2 with 10.0.22621.2428 SDK with ARM64 libraries and UWP support.
2121
# See go/chromium-msvc-toolchain for instructions about how to update the
2222
# toolchain.
2323
#
@@ -39,7 +39,7 @@
3939
# Maps between Visual Studio version and MSVC toolset
4040
# * MSVS_VERSIONS in this file
4141
# Records the packaged and default version of Visual Studio
42-
TOOLCHAIN_HASH = '27370823e7'
42+
TOOLCHAIN_HASH = '7393122652'
4343
SDK_VERSION = '10.0.22621.0'
4444

4545
script_dir = os.path.dirname(os.path.realpath(__file__))

0 commit comments

Comments
 (0)