Fix url and src in NotRestoredReasons #10916
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
url was previously listed as a DOMString, but it should be a USVString. This change is not observable since it always contained a serialized URL anyway. src was previously listed as containing the literal value of the src="" content attribute. However, the intended behavior was to contain the parsed-then-serialized value of the src IDL attribute, i.e., the result after content/IDL attribute reflection. Fix the spec to reflect that, which allows also changing it to USVString. Finally, also account for the fact that sometimes content attributes can be missing, in which case these properties need to return the empty string. (Not null, which is reserved for the top level or non-iframe child cases.) Closes #10895.
|
I'll give this a week in case @smaug---- wants to take a look, and plan on merging after that. |
smaug----
reviewed
Jan 17, 2025
| data-x="nav-container">container</span>'s <code data-x="attr-iframe-name">name</code> attribute.</p></li> | ||
| <li><p>Set <var>notRestoredReasonsForDocument</var>'s <span data-x="nrr-name">name</span> to | ||
| <var>container</var>'s <code data-x="attr-iframe-name">name</code> attribute's value, or the | ||
| empty string if it has no such attribute.</p></li> |
There was a problem hiding this comment.
Why empty string? https://html.spec.whatwg.org/#nrr-struct defaults to null anyhow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url was previously listed as a DOMString, but it should be a USVString. This change is not observable since it always contained a serialized URL anyway.
src was previously listed as containing the literal value of the src="" content attribute. However, the intended behavior was to contain the parsed-then-serialized value of the src IDL attribute, i.e., the result after content/IDL attribute reflection. Fix the spec to reflect that, which allows also changing it to USVString.
Finally, also account for the fact that sometimes content attributes can be missing, in which case these properties need to return the empty string. (Not null, which is reserved for the top level or non-iframe child cases.)
Closes #10895.
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/nav-history-apis.html ( diff )