Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding charset=utf-8 to CSS and SVG files? #91

Open
domenic opened this issue Apr 25, 2018 · 1 comment
Open

Consider adding charset=utf-8 to CSS and SVG files? #91

domenic opened this issue Apr 25, 2018 · 1 comment

Comments

@domenic
Copy link
Member

domenic commented Apr 25, 2018

Based on https://sonarwhal.com/scanner/82d0ae4e-aa8d-4b9b-9d32-24c1b0817136, we don't.

CSS inherits from the document, so this isn't really necessary except if people navigate to the CSS file directly.

For SVG I can't find a specification anywhere.

Maybe we should do JS, text, etc. while we're at it?

@annevk
Copy link
Member

annevk commented Apr 26, 2018

SVG would follow XML, no? So that would default to UTF-8. When you navigate to CSS or JavaScript directly it should also default to UTF-8 in theory, but browsers don't really do it that way.

But doing it for all of them is probably still a good idea so user agents can avoid going down more complicated code paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants