Skip to content
This repository was archived by the owner on Apr 15, 2024. It is now read-only.

Write unit tests for both packages #4

Closed
whizkydee opened this issue Apr 9, 2019 · 8 comments
Closed

Write unit tests for both packages #4

whizkydee opened this issue Apr 9, 2019 · 8 comments
Assignees
Labels
enhancement This would improve overall quality.

Comments

@whizkydee
Copy link
Owner

No description provided.

@whizkydee whizkydee added the enhancement This would improve overall quality. label Apr 9, 2019
@whizkydee whizkydee self-assigned this Apr 9, 2019
@samie820
Copy link
Contributor

samie820 commented Apr 14, 2019

Hi, I'm pretty new to contributing to monorepos, but I'll like to work on this feature for the React project

@whizkydee
Copy link
Owner Author

Hey @samie820,

That's great! It's nothing really crazy, I left some instructions in the Contributing section, feel free to take a look and let me know if you expereince any problems.

@samie820
Copy link
Contributor

thanks...followed the instructions, I was having issues with yarn install -W, ended up adding a private: true property to the package.json (read it on the yarn docs BTW). Also, if i'm setting up jest, do I install it in the react-dropd package?

@whizkydee
Copy link
Owner Author

Perfect! No need to install it in react-dropd. Yarn workspaces and lerna manage that. So, just install it in dropd.

@samie820
Copy link
Contributor

Oh cool, thanks

@whizkydee
Copy link
Owner Author

whizkydee commented Apr 15, 2019

Hey @samie820! Please checkout the new codebase. A lot has changed, including bug fixes and browser inconsistency fixes.

@samie820
Copy link
Contributor

Ok will do, I was about to make a PR, but let me check out the changes

@whizkydee
Copy link
Owner Author

Thanks for the work on this @samie820, I just merged to master, and published as v1.1.1 with a bunch of nice changes.

I've been really busy lately... at the same time, I've been thinking of the best way to test these components, and I'm glad to announce that I've found just the right solution -- Cypress!

I'll start the setup and migration this week and most likely publish with support for slots -- #3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement This would improve overall quality.
Projects
None yet
Development

No branches or pull requests

2 participants