Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position embedding is added inside each block? #2

Open
LinB203 opened this issue Feb 25, 2024 · 1 comment
Open

Position embedding is added inside each block? #2

LinB203 opened this issue Feb 25, 2024 · 1 comment

Comments

@LinB203
Copy link

LinB203 commented Feb 25, 2024

DiT is to add positional embedding once before the transformer block. And according to Figure 3 (c) of FiT's paper, it seems that the position embedding is added inside each block. Is this an unfair comparison?

@WZDTHU
Copy link
Collaborator

WZDTHU commented Oct 31, 2024

This is a common implementation of relative positional embedding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants