[Ray Log] remove glog dependency (ray-project#16077)

Author: qicosmos

BUILD.bazel

@@ -323,7 +323,6 @@ cc_library(
         ":ray_common",
         ":ray_util",
         "//src/ray/protobuf:common_cc_proto",
-        "@com_github_google_glog//:glog",
         "@msgpack",
     ],
 )
@@ -352,7 +351,6 @@ cc_library(
     strip_include_prefix = "src",
     deps = [
         ":plasma_client",
-        "@com_github_google_glog//:glog",
     ],
 )
 
@@ -1557,8 +1555,10 @@ cc_library(
         "//src/ray/protobuf:event_cc_proto",
         "@boost//:asio",
         "@boost//:property_tree",
-        "@com_github_google_glog//:glog",
         "@com_github_spdlog//:spdlog",
+        "@com_google_absl//absl/debugging:failure_signal_handler",
+        "@com_google_absl//absl/debugging:stacktrace",
+        "@com_google_absl//absl/debugging:symbolize",
         "@com_google_absl//absl/synchronization",
         "@com_google_absl//absl/time",
         "@com_google_googletest//:gtest_main",

bazel/ray.bzl

@@ -21,7 +21,7 @@ COPTS_WITHOUT_LOG = select({
     ],
 })
 
-COPTS = ["-DRAY_USE_SPDLOG"] + COPTS_WITHOUT_LOG
+COPTS = COPTS_WITHOUT_LOG
 
 PYX_COPTS = select({
     "//:msvc-cl": [

bazel/ray_deps_setup.bzl

@@ -24,9 +24,7 @@ def auto_http_archive(*, name=None, url=None, urls=True,
                       build_file=None, build_file_content=None,
                       strip_prefix=True, **kwargs):
     """ Intelligently choose mirrors based on the given URL for the download.
-
     Either url or urls is required.
-
     If name         == None , it is auto-deduced, but this is NOT recommended.
     If urls         == True , mirrors are automatically chosen.
     If build_file   == True , it is auto-deduced.
@@ -181,18 +179,6 @@ def ray_deps_setup():
         sha256 = "b20f58e7f210ceb0e768eb1476073d0748af9b19dfbbf53f4fd16e3fb49c5ac8",
     )
 
-    auto_http_archive(
-        name = "com_github_google_glog",
-        url = "https://github.com/google/glog/archive/925858d9969d8ee22aabc3635af00a37891f4e25.tar.gz",
-        sha256 = "fb86eca661497ac6f9ce2a106782a30215801bb8a7c8724c6ec38af05a90acf3",
-        patches = [
-            "//thirdparty/patches:glog-log-pid-tid.patch",
-            "//thirdparty/patches:glog-stack-trace.patch",
-            "//thirdparty/patches:glog-suffix-log.patch",
-            "//thirdparty/patches:glog-dump-stacktrack.patch",
-        ],
-    )
-
     auto_http_archive(
         name = "cython",
         build_file = True,
@@ -214,8 +200,8 @@ def ray_deps_setup():
     # This is how diamond dependencies are prevented.
     auto_http_archive(
         name = "com_google_absl",
-        url = "https://github.com/abseil/abseil-cpp/archive/aa844899c937bde5d2b24f276b59997e5b668bde.tar.gz",
-        sha256 = "327a3883d24cf5d81954b8b8713867ecf2289092c7a39a9dc25a9947cf5b8b78",
+        url = "https://github.com/abseil/abseil-cpp/archive/278e0a071885a22dcd2fd1b5576cc44757299343.tar.gz",
+        sha256 = "1764491a199eb9325b177126547f03d244f86b4ff28f16f206c7b3e7e4f777ec",
     )
 
     # OpenCensus depends on jupp0r/prometheus-cpp

python/ray/tests/BUILD

@@ -43,6 +43,7 @@ py_test_module_list(
     "test_get_locations.py",
     "test_global_state.py",
     "test_healthcheck.py",
+    "test_kill_raylet_signal_log.py",
     "test_mldataset.py",
   ],
   size = "medium",

python/ray/tests/test_kill_raylet_signal_log.py

@@ -0,0 +1,42 @@
+import psutil
+import signal
+import sys
+import pytest
+import ray
+
+
+def get_pid(name):
+    pids = psutil.process_iter()
+    for pid in pids:
+        if name in pid.name():
+            return pid.pid
+
+    return -1
+
+
+def check_result(filename, num_signal, check_key):
+    ray.init(num_cpus=1)
+    session_dir = ray.worker._global_node.get_session_dir_path()
+    raylet_out_path = filename.format(session_dir)
+    pid = get_pid("raylet")
+    assert pid > 0
+    p = psutil.Process(pid)
+    p.send_signal(num_signal)
+    p.wait(timeout=15)
+    with open(raylet_out_path) as f:
+        s = f.read()
+        assert check_key in s
+
+
+@pytest.mark.skipif(sys.platform == "win32", reason="Not support on Windows.")
+def test_kill_raylet_signal_log(shutdown_only):
+    check_result("{}/logs/raylet.err", signal.SIGABRT, "SIGABRT")
+
+
+@pytest.mark.skipif(sys.platform != "win32", reason="Only run on Windows.")
+def test_kill_raylet_signal_log_win(shutdown_only):
+    check_result("{}/logs/raylet.out", signal.CTRL_BREAK_EVENT, "SIGTERM")
+
+
+if __name__ == "__main__":
+    sys.exit(pytest.main(["-v", __file__]))