Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getBoundingClientRect error in ssr applications #76

Closed
wants to merge 2 commits into from
Closed

fix getBoundingClientRect error in ssr applications #76

wants to merge 2 commits into from

Conversation

urohith17
Copy link

@urohith17 urohith17 commented Nov 29, 2020

Added condition to skip the dom api call getBoundingClientRect() on server. This change fixes #63

@wittlock
Copy link
Owner

There's some conflict between this pr and a recently merged one. If you update it I'd be happy to test and merge this one too.

@wittlock wittlock added the needs work Pull request needs some fixes label Apr 28, 2022
@wittlock
Copy link
Owner

Closing this due to lack of progress. Feel free to open a new one if interest resurfaces.

@wittlock wittlock closed this Apr 15, 2023
@DDurakISH
Copy link

DDurakISH commented Oct 27, 2023

You have not been able to fix a conflict in 8 lines of code?
Please go a head merging this fix or provide a solid SSR fix solution.
@urohith173 don't you follow this topic anymore?

@ghost
Copy link

ghost commented Oct 27, 2023

I am not following the repo currently. that's why i couldn't reply to the comments. @DDurakISH thanks for bringing it to my attention by tagging me i will look into the conflicts and create a new pr.

@ghost
Copy link

ghost commented Oct 27, 2023

@DDurakISH @wittlock no new pr is required as the current code in master branch will not result in this issue.

@DDurakISH
Copy link

@urohith17 thank you very much for your investigation and response!

@ghost
Copy link

ghost commented Oct 27, 2023

Note: the issue still exists in the current latest version 2.1.0. So the next release should fix it.

@wittlock
Copy link
Owner

wittlock commented Oct 27, 2023 via email

@wittlock
Copy link
Owner

Alright. Weekend got away from me, but now there's a 3.0.0 up at npm. I hope this works as expected and sorts your ssr related issues. Let me know if there's anything wonky with it.

@ghost
Copy link

ghost commented Nov 2, 2023

Working fine 👍.

@ghost
Copy link

ghost commented Nov 2, 2023

I think you can close the issue #63 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work Pull request needs some fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with server side Rendering
3 participants