Skip to content

inconsistent slider in the 2d matrix effect #4659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RiWi-creator opened this issue Apr 23, 2025 · 1 comment
Open

inconsistent slider in the 2d matrix effect #4659

RiWi-creator opened this issue Apr 23, 2025 · 1 comment
Labels
backburner low priority compared to other issues enhancement

Comments

@RiWi-creator
Copy link

Wled Nightly release 2025-04-20
2D matrix effect:
The scroll bar from the trail length is inverted.
0=maximum length trail
and
255=minimum length trail

In the file 'FX.cpp'
CODE:
At line 5387:
uint8_t fade = map(SEGMENT.custom1, 0, 255, 50, 250); // equals trail size

SOLUTION:
Change to:
uint8_t fade = map(255-SEGMENT.custom1, 0, 255, 50, 250); // equals trail size

Thank you.
Keep up the good work.
greetings,
RiWi-creator

@blazoncek
Copy link
Collaborator

Make a PR if you wish. However be mindful that current behaviour is implemented for over a year and many users may have presets set-up which will work incorrectly after the change.

@blazoncek blazoncek added the backburner low priority compared to other issues label Apr 24, 2025
@blazoncek blazoncek changed the title bug in the 2d matrix effect inconsistent slider in the 2d matrix effect Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backburner low priority compared to other issues enhancement
Projects
None yet
Development

No branches or pull requests

2 participants