Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site changes are not reflected when fetching it on app launch #13523

Open
hichamboushaba opened this issue Feb 11, 2025 · 1 comment
Open

Site changes are not reflected when fetching it on app launch #13523

hichamboushaba opened this issue Feb 11, 2025 · 1 comment
Labels
type: bug A confirmed bug.

Comments

@hichamboushaba
Copy link
Member

Currently, the selected site is cached in memory in SelectedSite, and when the app refreshes the site information on app launch (and when resuming from background), we don't update the in-memory version, which requires force closing the app and relaunching it to pick those changes.

  • We need to ensure that we update the site after fetching it.
  • Look into implementing equals on the SiteModel to avoid useless notifications to the observers.
@dangermattic
Copy link
Collaborator

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A confirmed bug.
Projects
None yet
Development

No branches or pull requests

2 participants