Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigating scroll to the top of the screen when re-selecting the current tab. #13524

Open
JorgeMucientes opened this issue Feb 11, 2025 · 1 comment
Labels
type: bug A confirmed bug.

Comments

@JorgeMucientes
Copy link
Contributor

Nothing happens when re-selecting the current tab. It should scroll to the top of the screen when doing this.
One thing I noticed is scrollToTop() function from TopLeverFragment is never called when re-selecting the tab. This happens to all the other tabs as well and it is because getActiveTopLevelFragment() returns null always, when reselecting any tab. I don't know since when this is broken and haven't had the time to dig deper

Additionally review shouldExpandToolbar() for DashboardFragment to ensure the collapsing toolbar is shown collapsed when navigating back to My Store and the scroll position is not at the top.

@JorgeMucientes JorgeMucientes added the type: bug A confirmed bug. label Feb 11, 2025
@dangermattic
Copy link
Collaborator

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A confirmed bug.
Projects
None yet
Development

No branches or pull requests

2 participants