ACSS: Refactor unsupported deferred intent in the blocks checkout #3866
Conversation
…merce/woocommerce-gateway-stripe into fix/3804-refactor-deferred-intent
Co-authored-by: César Costa <[email protected]>
Co-authored-by: César Costa <[email protected]>
…merce/woocommerce-gateway-stripe into fix/3804-refactor-deferred-intent
ricardo
changed the base branch from
develop
to
fix/3804-refactor-deferred-intent
| appearance, | ||
| paymentMethodCreation: 'manual', | ||
| fonts: getFontRulesFromPage(), |
There was a problem hiding this comment.
Here we're also fixing a missing fonts prop which resulted in a minor style issue:
Before:
After:
|
Assigned @cesarcosta99 and @wjrosa as reviewers since this PR is a follow up from #3805. |
There was a problem hiding this comment.
Code is good and works as expected! I was able to place an order following the test steps.
One bug I noticed (maybe it is something related to my environment only) is that if I don't provide a phone number I get the following error:
If it is something happening to everyone, we need to make the phone number required for this method.
There was a problem hiding this comment.
Code looks good and tests well 🎉 I spotted some issues, though:
- I experienced the same as @wjrosa and get the error
Please provide complete payment details.when I don't provide a phone number. I tested this in both classic and Blocks checkouts and both errored. We'll likely need to enforce a phone requirement in the forms, maybe not something to address in this PR, but at least something to add to ACSS: Handle Errors and Edge Cases #3830. - When trying to checkout with ACSS in a clean session (e.g. incognito mode), the payment method doesn't display as I fill out the form. Instead, I need to refresh the page to be able to see and select the method. I only experienced this in Blocks checkout:
output.mp4
| try { | ||
| const response = await api.createIntent( | ||
| getBlocksConfiguration()?.orderId, | ||
| props.paymentMethodId |
There was a problem hiding this comment.
Is paymentMethodId passed only when deferred intent is not supported? If not, I think it'd look more consistent to destructure it as we're doing with other props.
Fixes #3851
This PR is complementary to #3805.
Changes proposed in this Pull Request:
Testing instructions
Follow testing instructions from #3805, but using the blocks checkout.
changelog.txtandreadme.txt(or does not apply)Post merge